Skip to content

[no-release-notes] Add regression test for long trigger names #9660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fulghum merged 3 commits into from
Aug 11, 2025
Merged

[no-release-notes] Add regression test for long trigger names #9660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0461f3b
Add regression test for join of dolt_schemas with information_schema.…
fulghum Aug 11, 2025
513b31b
Bump GMS dependency to latest from fulghum/trigger_name_length dev br…
fulghum Aug 11, 2025
b64b225
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/upda…
fulghum Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ require (
github.com/dolthub/aws-sdk-go-ini-parser v0.0.0-20250305001723-2821c37f6c12
github.com/dolthub/eventsapi_schema v0.0.0-20250725194025-a087efa1ee55
github.com/dolthub/flatbuffers/v23 v23.3.3-dh.2
github.com/dolthub/go-mysql-server v0.20.1-0.20250811061414-a2ed59d23655
github.com/dolthub/go-mysql-server v0.20.1-0.20250811202827-729f4f519985
github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63
github.com/edsrzf/mmap-go v1.2.0
github.com/esote/minmaxheap v1.0.0
Expand Down
4 changes: 2 additions & 2 deletions go/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,8 @@ github.com/dolthub/fslock v0.0.3 h1:iLMpUIvJKMKm92+N1fmHVdxJP5NdyDK5bK7z7Ba2s2U=
github.com/dolthub/fslock v0.0.3/go.mod h1:QWql+P17oAAMLnL4HGB5tiovtDuAjdDTPbuqx7bYfa0=
github.com/dolthub/go-icu-regex v0.0.0-20250327004329-6799764f2dad h1:66ZPawHszNu37VPQckdhX1BPPVzREsGgNxQeefnlm3g=
github.com/dolthub/go-icu-regex v0.0.0-20250327004329-6799764f2dad/go.mod h1:ylU4XjUpsMcvl/BKeRRMXSH7e7WBrPXdSLvnRJYrxEA=
github.com/dolthub/go-mysql-server v0.20.1-0.20250811061414-a2ed59d23655 h1:Y+WL+Gz+9sQexf09TrDXDSP4DHNOAvGLeGSt+/f0qZM=
github.com/dolthub/go-mysql-server v0.20.1-0.20250811061414-a2ed59d23655/go.mod h1:bm6qjZ7/4B65nVfGBWKBPz4BsrFKzMxNwsk3c1fasis=
github.com/dolthub/go-mysql-server v0.20.1-0.20250811202827-729f4f519985 h1:F0FkSaCZGYhFysWekZJ9GBMZX9hb3z4W1jltSPgguiU=
github.com/dolthub/go-mysql-server v0.20.1-0.20250811202827-729f4f519985/go.mod h1:bm6qjZ7/4B65nVfGBWKBPz4BsrFKzMxNwsk3c1fasis=
github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63 h1:OAsXLAPL4du6tfbBgK0xXHZkOlos63RdKYS3Sgw/dfI=
github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63/go.mod h1:lV7lUeuDhH5thVGDCKXbatwKy2KW80L4rMT46n+Y2/Q=
github.com/dolthub/ishell v0.0.0-20240701202509-2b217167d718 h1:lT7hE5k+0nkBdj/1UOSFwjWpNxf+LCApbRHgnCA17XE=
Expand Down
20 changes: 20 additions & 0 deletions go/libraries/doltcore/sqle/enginetest/dolt_queries.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1438,6 +1438,26 @@ var DoltScripts = []queries.ScriptTest{
},
},
},
{
// Regression test for a customer-reported issue where the length of the
// information_schema.triggers.name column was too short for a long trigger name.
Name: "join dolt_schemas on information_schema.triggers for a trigger with a long name",
SetUpScript: []string{
`CREATE TABLE example_table (id INT AUTO_INCREMENT PRIMARY KEY, value VARCHAR(50));`,
`CREATE TRIGGER this_is_a_trigger_name_that_is_exactly_sixty_five_characters_long
BEFORE INSERT ON example_table
FOR EACH ROW BEGIN SET NEW.value = UPPER(NEW.value); END;`,
},
Assertions: []queries.ScriptTestAssertion{
{
Query: `SELECT t.trigger_name, length(s.fragment)
FROM information_schema.triggers t
JOIN dolt_schemas s ON s.type = 'trigger' AND s.name = t.TRIGGER_NAME
WHERE t.EVENT_OBJECT_TABLE IN ('example_table');`,
Expected: []sql.Row{{"this_is_a_trigger_name_that_is_exactly_sixty_five_characters_long", 178}},
},
},
},
{
Name: "test hashof",
SetUpScript: []string{
Expand Down
Loading