Skip to content

[no-release-notes] Add regression test for long trigger names#9660

Merged
fulghum merged 3 commits intomainfrom
fulghum/trigger_name_length
Aug 11, 2025
Merged

[no-release-notes] Add regression test for long trigger names#9660
fulghum merged 3 commits intomainfrom
fulghum/trigger_name_length

Conversation

@fulghum
Copy link
Contributor

@fulghum fulghum commented Aug 11, 2025

A customer reported an issue with a query that joined the dolt_schemas table with the information_schema.triggers table. Due to a trigger name exceeding the schema limit of 64 chars, the data wasn't able to be converted into a result. The fix for this issue is in dolthub/go-mysql-server#3152 and this PR adds an additional regression test to Dolt, with the exact customer query.

@github-actions
Copy link

This PR is being tested for SQL correctness. Please allow ~25 mins for this to complete. If this PR does not result in a SQL correctness regression, the correctness_approved label will be automatically added to this PR and the Check for correctness_approved workflow will succeed.

@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
513b31b ok 5937457
version total_tests
513b31b 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
b64b225 ok 5937457
version total_tests
b64b225 5937457
correctness_percentage
100.0

Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fulghum fulghum merged commit 6c37c55 into main Aug 11, 2025
19 of 22 checks passed
@fulghum fulghum deleted the fulghum/trigger_name_length branch August 11, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants