Bug fix: ensure dolt_checkout() initializes a branch's working set#9648
Merged
Bug fix: ensure dolt_checkout() initializes a branch's working set#9648
dolt_checkout() initializes a branch's working set#9648Conversation
fulghum
force-pushed
the
fulghum/checkout_ws_init
branch
from
a422803 to
092545d
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dolt_checkout()already had logic to initialize a branch's working set if one was not available, but the error it expected to see to trigger that logic was not being returned by the functions it called. This changes thecheckoutExistingBranch()function so that it also resolves the working set for that branch and returns adoltdb.ErrWorkingSetNotFounderror if the working set is not available.