Skip to content

Add a smoke test for server-side cursor support#9141

Merged
fulghum merged 4 commits intomainfrom
fulghum/cursor_smoke_test
Apr 23, 2025
Merged

Add a smoke test for server-side cursor support#9141
fulghum merged 4 commits intomainfrom
fulghum/cursor_smoke_test

Conversation

@fulghum
Copy link
Contributor

@fulghum fulghum commented Apr 22, 2025

Adds smoke test coverage for server-side cursor support. Motivated by the customer issue linked below with corrupted results from SHOW COLLATION; while using DBVisualizer when a server-side cursor is in use.

A run without the fix from GMS shows how this new test fails when the bug from the customer is triggered.

Depends on: dolthub/go-mysql-server#2952

Related to: #9125

@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
cf455f8 ok 5937457
version total_tests
cf455f8 5937457
correctness_percentage
100.0

Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fulghum fulghum merged commit bcbcbc0 into main Apr 23, 2025
11 checks passed
@fulghum fulghum deleted the fulghum/cursor_smoke_test branch April 23, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants