Merged
Conversation
iMichka
approved these changes
Apr 24, 2025
Contributor
|
🤖 An automated task has requested bottles to be published to this PR. Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.Details
release notes
Fixes: Dolt merge fails when schema change drops multiple referenced tables dolthub/dolt#9014
Adds smoke test coverage for server-side cursor support. Motivated by the customer issue linked below with corrupted results from
SHOW COLLATION;while using DBVisualizer when a server-side cursor is in use.A run without the fix from GMS shows how this new test fails when the bug from the customer is triggered.
Depends on: Only release buffer when a server-side cursor is not in use dolthub/go-mysql-server#2952
Related to: Errors serializing data when cursors are in use dolthub/dolt#9125
This PR modifies
doGCto stop statistics before running, and restart statistics afterwards. An earlier version of this PR threaded cancellations through the session management interface, but that created headaches for invalidating looping stats sessions.For more background, stats jobs were previously partitioned into sections that allow GC to finalize before stats finishes. The nature of this partitioning creates a dependency chain between reading the histogram chunk level of an index, and jobs that read those individual chunk subtrees. The problem is that those jobs create a read-dependency that is broken when GC deletes chunks. The nature of the partitioning means the only way to avoid the interruption is to (1) stall GC for a longer period of time, (2) check chunk integrity before every subcommands, or (3) invalidate the stats session.
Additionally, this fixes the long flush issue where queries would stall on writing up to 65k stats rows to disk. We limit pending stats changes to 64, which upper bounds the cost of any single flush in a way that meshes with current rate-limiting methodology.
gms side: [no-release-notes] track join memos for external use dolthub/go-mysql-server#2917
go-mysql-server
We added an optimization to release a row's memory after sending it over the channel, but for a server-side cursor, there is another layer of spooling involved, so it's not safe to release the row memory yet. This changes that optimization to only release the row's memory when we are not using a server-side cursor.
Testing this server-side cursor behavior requires a little extra work.
go-sql-driver/mysqldoes not support server-side cursors, so we can't test this directly in our Go code. I've opened Add a smoke test for server-side cursor support dolthub/dolt#9141 with changes to our Java MySQL Connector/J integration tests to add some simple smoke tests for server-side cursors that triggers the same behavior as the customer reported issue below.Fixes: Errors serializing data when cursors are in use dolthub/dolt#9125
fixes: Update MySQL version to 8.0.31 so that Django recognizes support for INTERSECT and EXCEPT? dolthub/go-mysql-server#2950
vitess
RETURNINGtoUPDATEandINSERTnodesThis PR adds makes it so that
TRIM,CASTandPOSITIONare usable as table and column names without backquotes.fixes: BUG: Dolt treats
positionas a reserved keyword dolthub/dolt#9123Closed Issues
coalesce()unescaping json with new lines