Conversation
…on lifecycle validation at the storage layer. Enable checks for bats and go sql server integration tests. This makes *NomsBlockStore check the incoming Context object to ensure that it itself has been invovled in the appropriate GC lifecycle callbacks. It fixes a problem with statspro.AnalyzeTable, where the GC lifecycle callbacks happened more than once for a single session. It fixes some callsites to appropriately make the GC lifecycle callbacks, including LateBindingQueryist opening one session command for the whole lifetime of the returned sql.Context.
max-hoffman
approved these changes
Mar 29, 2025
Contributor
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
lgtm, tricky edge case
|
|
||
| sqlCtx, err := se.NewDefaultContext(ctx) | ||
| if err != nil { | ||
| return nil, nil, nil, err |
Contributor
There was a problem hiding this comment.
does this one need se.Close()? should we defer check if err != nil for closing every error retur?
Contributor
… simple smoke tests to assert that valctx is enabled for these test suites.
Contributor
Contributor
|
@coffeegoddd DOLT
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes *NomsBlockStore check the incoming Context object to ensure that it itself has been invovled in the appropriate GC lifecycle callbacks.
It fixes a problem with statspro.AnalyzeTable, where the GC lifecycle callbacks happened more than once for a single session.
It fixes some callsites to appropriately make the GC lifecycle callbacks, including LateBindingQueryist opening one session command for the whole lifetime of the returned sql.Context.