Skip to content

integration-tests/go-sql-server-driver: Move max-connections testing to go-sql-server-driver.#9032

Merged
reltuk merged 6 commits intomainfrom
aaron/max-connections-tests-go-sql-server-driver
Mar 27, 2025
Merged

integration-tests/go-sql-server-driver: Move max-connections testing to go-sql-server-driver.#9032
reltuk merged 6 commits intomainfrom
aaron/max-connections-tests-go-sql-server-driver

Conversation

@reltuk
Copy link
Copy Markdown
Contributor

@reltuk reltuk commented Mar 25, 2025

No description provided.

@reltuk reltuk changed the base branch from macneale4-a127ac54 to main March 26, 2025 00:14
@reltuk reltuk closed this Mar 26, 2025
@reltuk reltuk reopened this Mar 26, 2025
@coffeegoddd
Copy link
Copy Markdown
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
9773be1 ok 5937457
version total_tests
9773be1 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
ea75563 ok 5937457
version total_tests
ea75563 5937457
correctness_percentage
100.0

Copy link
Copy Markdown
Contributor

@macneale4 macneale4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just added a suggested comment on the test helper method. It's the key to the whole thing!

…st.go

Co-authored-by: Neil Macneale IV <46170177+macneale4@users.noreply.github.com>
@coffeegoddd
Copy link
Copy Markdown
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
2d67459 ok 5937457
version total_tests
2d67459 5937457
correctness_percentage
100.0

@reltuk reltuk merged commit 707ccf7 into main Mar 27, 2025
21 checks passed
@tbantle22 tbantle22 deleted the aaron/max-connections-tests-go-sql-server-driver branch May 28, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants