Skip to content

Test new connection configuration in vitess#9028

Merged
macneale4 merged 16 commits intomainfrom
macneale4-a127ac54
Mar 25, 2025
Merged

Test new connection configuration in vitess#9028
macneale4 merged 16 commits intomainfrom
macneale4-a127ac54

Conversation

@coffeegoddd
Copy link
Copy Markdown
Contributor

@coffeegoddd coffeegoddd commented Mar 24, 2025

This PR is both a dependency bump and enabling the configuration args in the dependency.

@coffeegoddd coffeegoddd added the gms-bump pr that bumps the go-mysql-server version label Mar 24, 2025
@coffeegoddd coffeegoddd requested a review from zachmu March 24, 2025 22:05
@macneale4 macneale4 added the keep-alive prevent auto-closing pr label Mar 24, 2025
@macneale4 macneale4 requested a review from reltuk March 24, 2025 22:19
@macneale4 macneale4 changed the title [auto-bump] [no-release-notes] dependency by macneale4 Test new connection configuration in vitess Mar 24, 2025
@coffeegoddd
Copy link
Copy Markdown
Contributor Author

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
f8a966b ok 5937457
version total_tests
f8a966b 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor Author

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
69f5371 ok 5937457
version total_tests
69f5371 5937457
correctness_percentage
100.0

@macneale4 macneale4 removed the request for review from zachmu March 25, 2025 00:50
@coffeegoddd
Copy link
Copy Markdown
Contributor Author

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
b4a3257 ok 5937457
version total_tests
b4a3257 5937457
correctness_percentage
100.0

@macneale4 macneale4 force-pushed the macneale4-a127ac54 branch from b4a3257 to 24c4e7c Compare March 25, 2025 04:02
@coffeegoddd
Copy link
Copy Markdown
Contributor Author

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
24c4e7c ok 5937457
version total_tests
24c4e7c 5937457
correctness_percentage
100.0

Copy link
Copy Markdown
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me.

I think the minVer stuff is necessary if we don't want to break hosted, but I'm not 100% sure.

One comment about a test name.

I took the liberty of porting these tests to go-sql-server-driver to see what it would look like: #9032. They run in 20s, never leak a process and have more precise assertions. They run in 14s when ported to run in parallel. They caught the continue bug whereas I don't think these bats tests originally did.

On the other hand, they're slightly more verbose and probably a bit harder to write. And they don't benefit from lambdabats. So...tradeoffs.

reltuk and others added 3 commits March 25, 2025 15:02
… format it for presentation. Better matches the behavior of these timestamps on the wire.
@coffeegoddd
Copy link
Copy Markdown
Contributor Author

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
9f47fa9 ok 5937457
version total_tests
9f47fa9 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor Author

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
8a73e44 ok 5937457
version total_tests
8a73e44 5937457
correctness_percentage
100.0

@macneale4
Copy link
Copy Markdown
Contributor

Aaron gave the 👍 in DM.

@macneale4 macneale4 merged commit f1135ce into main Mar 25, 2025
21 checks passed
@tbantle22 tbantle22 deleted the macneale4-a127ac54 branch May 28, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

correctness_approved gms-bump pr that bumps the go-mysql-server version keep-alive prevent auto-closing pr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants