Test new connection configuration in vitess#9028
Merged
Conversation
Contributor
Author
|
@coffeegoddd DOLT
|
Contributor
Author
|
@macneale4 DOLT
|
Contributor
Author
|
@macneale4 DOLT
|
No tests. No SQL support
b4a3257 to
24c4e7c
Compare
Contributor
Author
|
@macneale4 DOLT
|
reltuk
reviewed
Mar 25, 2025
Contributor
reltuk
left a comment
There was a problem hiding this comment.
Generally looks good to me.
I think the minVer stuff is necessary if we don't want to break hosted, but I'm not 100% sure.
One comment about a test name.
I took the liberty of porting these tests to go-sql-server-driver to see what it would look like: #9032. They run in 20s, never leak a process and have more precise assertions. They run in 14s when ported to run in parallel. They caught the continue bug whereas I don't think these bats tests originally did.
On the other hand, they're slightly more verbose and probably a bit harder to write. And they don't benefit from lambdabats. So...tradeoffs.
…ounding instead of truncation.
… format it for presentation. Better matches the behavior of these timestamps on the wire.
Contributor
Author
Contributor
Author
|
@macneale4 DOLT
|
Contributor
|
Aaron gave the 👍 in DM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is both a dependency bump and enabling the configuration args in the dependency.