Conversation
…ery out of dsess and into its own, sql-agnostic package.
…e correctly enbapsulates the async load of the autoincrement state.
… safepoint controller exists.
Contributor
zachmu
approved these changes
Mar 24, 2025
| sessions map[GCRootsProvider]*GCSafepointSessionState | ||
| } | ||
|
|
||
| type GCRootsProvider interface { |
Member
There was a problem hiding this comment.
Probably needs a doc for the type and its method
| @@ -450,10 +470,8 @@ func (a *AutoIncrementTracker) waitForInit() error { | |||
| } | |||
|
|
|||
| func (a *AutoIncrementTracker) runInitWithRootsAsync(ctx context.Context, roots ...doltdb.Rootish) { | |||
Member
There was a problem hiding this comment.
You have changed the semantics of this method to no longer be async. You've added asyncness back in the one use I see in the diff below, but a) change the name, and b) if there are other uses that expect async behavior, they need to be changed as well
Contributor
|
@coffeegoddd DOLT
|
|
@coffeegoddd DOLT
|
|
@coffeegoddd DOLT
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.