Skip to content

Fix InsertID discrepancy tests#8970

Merged
jycor merged 4 commits intomainfrom
james/last_insert
Mar 11, 2025
Merged

Fix InsertID discrepancy tests#8970
jycor merged 4 commits intomainfrom
james/last_insert

Conversation

@jycor
Copy link
Copy Markdown
Contributor

@jycor jycor commented Mar 11, 2025

Fixes tests involving OKPacket's InsertID not aligning with last_insert_id.

related: #8914
bump: dolthub/go-mysql-server#2886

@jycor jycor changed the title James/last insert Fix InsertID discrepancy tests Mar 11, 2025
@coffeegoddd
Copy link
Copy Markdown
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
4f59298 ok 5937457
version total_tests
4f59298 5937457
correctness_percentage
100.0

Copy link
Copy Markdown
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coffeegoddd
Copy link
Copy Markdown
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
b6ea658 ok 5937457
version total_tests
b6ea658 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
bdb46a8 ok 5937457
version total_tests
bdb46a8 5937457
correctness_percentage
100.0

@jycor jycor merged commit 007d33c into main Mar 11, 2025
21 checks passed
@jycor jycor deleted the james/last_insert branch March 11, 2025 23:17
@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.07 1.14
batching batch sql 10000 1 0.09 1.33
batching by line sql 10000 1 0.08 1.5
blob 1 blob 200000 1 0.91 3.7 4.43
blob 2 blobs 200000 1 0.88 4.35 4.72
blob no blob 200000 1 0.94 2.33 2.7
col type datetime 200000 1 0.83 2.41 2.66
col type varchar 200000 1 0.71 3.23 3.7
config width 2 cols 200000 1 0.8 2.47 3.72
config width 32 cols 200000 1 1.9 1.95 2.69
config width 8 cols 200000 1 1.01 2.29 2.55
pk type float 200000 1 0.84 2.43 2.68
pk type int 200000 1 1.05 2 2.09
pk type varchar 200000 1 1.51 1.7 2.02
row count 1.6mm 1600000 1 5.72 2.95 2.88
row count 400k 400000 1 1.51 2.73 2.77
row count 800k 800000 1 2.91 2.86 2.82
secondary index four index 200000 1 3.64 1.39 1.29
secondary index no secondary 200000 1 0.95 2.4 2.71
secondary index one index 200000 1 1.13 2.42 2.54
secondary index two index 200000 1 2.04 1.76 1.78
sorting shuffled 1mm 1000000 0 5.02 2.83 2.68
sorting sorted 1mm 1000000 1 4.84 2.95 2.79

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.18
dolt_blame_commit_filter system table 2.95
dolt_commit_ancestors_commit_filter system table 0.61
dolt_commits_commit_filter system table 1.11
dolt_diff_log_join_from_commit system table 2.75
dolt_diff_log_join_to_commit system table 2.7
dolt_diff_table_from_commit_filter system table 1.13
dolt_diff_table_to_commit_filter system table 1.16
dolt_diffs_commit_filter system table 1
dolt_history_commit_filter system table 1.3
dolt_log_commit_filter system table 1

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.13
adds_updates_deletes 60000 60000 60000 4.48
deletes_only 0 60000 0 2.43
updates_only 0 0 60000 3.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants