Merged
Conversation
nandahkrishna
approved these changes
Mar 13, 2025
Contributor
|
🤖 An automated task has requested bottles to be published to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.Details
release notes
Cluster replication creates a system database,
dolt_cluster, which does not support transactions. There are also UserSpaceDatabases which do not support CreateTransaction. CreateTransaction has special code to avoid visiting them when recording the start transaction state. CreateSavepoint needed to be updated with that logic as well.Adds the ability to queue notice messages in the session, for them to be sent to the client during the execution phase. Related to Support for
RAISEin PL/pgSQL dolthub/doltgresql#1255.Fixes tests involving OKPacket's InsertID not aligning with
last_insert_id.related: MySQL is not consistent regarding
last_insert_id;go-mysql-serverceased to emulate this inconsistency in v0.19.0 dolthub/dolt#8914bump: reintroduce
last_insert_iddiscrepancy dolthub/go-mysql-server#2886go-mysql-server
last_insert_iddiscrepancyApparently the
last_insert_idin ok result, is not the same asselect last_insert_id().When there is an auto_increment column, the insert_id in the OKResult is the first value that increments the auto_increment value.
Reverts some changes from: fix insert id dolthub/go-mysql-server#2616
fixes: MySQL is not consistent regarding
last_insert_id;go-mysql-serverceased to emulate this inconsistency in v0.19.0 dolthub/dolt#8914This fixes a bug where a sort expression alias computed in the lower projection fails to index the nested expression.
Below, the first plan's sort searches for
c5:6in the child, but only findsa:7. The second plan fixes the correctness issue. Obviously there are more desirable projection organizations that version two, but this is small enough of an edge case that I think rewriting projection management with proper expression interning would be overkill right now. The rest of the plan tests look OK/improvements.Closed Issues
last_insert_id;go-mysql-serverceased to emulate this inconsistency in v0.19.0