Skip to content

go/store/nbs: Move to golang maps instead of dolthub/swiss.#8902

Merged
reltuk merged 2 commits intomainfrom
aaron/remove-swiss
Mar 6, 2025
Merged

go/store/nbs: Move to golang maps instead of dolthub/swiss.#8902
reltuk merged 2 commits intomainfrom
aaron/remove-swiss

Conversation

@reltuk
Copy link
Copy Markdown
Contributor

@reltuk reltuk commented Feb 27, 2025

No description provided.

@reltuk
Copy link
Copy Markdown
Contributor Author

reltuk commented Feb 27, 2025

#benchmark

@github-actions
Copy link
Copy Markdown

@coffeegoddd
Copy link
Copy Markdown
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
5897970 ok 5937457
version total_tests
5897970 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@reltuk DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 58.92 58.92 0.0
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 1b0f660 40.72 dolt 5897970 40.17 -1.35

@coffeegoddd
Copy link
Copy Markdown
Contributor

@reltuk DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.64 0.65 1.56
groupby_scan 17.95 17.95 0.0
index_join 2.61 2.52 -3.45
index_join_scan 1.5 1.44 -4.0
index_scan 30.81 30.26 -1.79
oltp_point_select 0.27 0.27 0.0
oltp_read_only 5.28 5.28 0.0
select_random_points 0.6 0.6 0.0
select_random_ranges 0.62 0.62 0.0
table_scan 32.53 32.53 0.0
types_table_scan 112.67 112.67 0.0
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.32 6.32 0.0
oltp_insert 3.13 3.13 0.0
oltp_read_write 11.65 11.65 0.0
oltp_update_index 3.19 3.19 0.0
oltp_update_non_index 3.07 3.13 1.95
oltp_write_only 6.32 6.43 1.74
types_delete_insert 6.67 6.67 0.0

@reltuk reltuk requested a review from max-hoffman March 5, 2025 22:37
Copy link
Copy Markdown
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +738 to +739
trace.Logf(ctx, "swiss map current count", "%d", len(idx.cached))
trace.Logf(ctx, "swiss map add count", "%d", len(idx.novel))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated but word references to swiss map maybe don't make sense anymore

@coffeegoddd
Copy link
Copy Markdown
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
3797530 ok 5937457
version total_tests
3797530 5937457
correctness_percentage
100.0

@reltuk reltuk merged commit d5d3c90 into main Mar 6, 2025
21 checks passed
@tbantle22 tbantle22 deleted the aaron/remove-swiss branch May 28, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants