Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize schema names in foreign key constraints #8461

Merged
merged 10 commits into from
Oct 17, 2024
Merged

Serialize schema names in foreign key constraints #8461

merged 10 commits into from
Oct 17, 2024

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Oct 16, 2024

No description provided.

@zachmu zachmu mentioned this pull request Oct 16, 2024
Merged
Hydrocharged
Hydrocharged approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Although looks like there's a little bit left to fix, I'm assuming from merging main.

go/libraries/doltcore/sqle/tables.go Show resolved Hide resolved
@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
737281d ok 5937457
version total_tests
737281d 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
1f6d3d1 ok 5937457
version total_tests
1f6d3d1 5937457
correctness_percentage
100.0

@zachmu zachmu merged commit 5bf1898 into main Oct 17, 2024
21 of 22 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Oct 17, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zachmu @coffeegoddd @Hydrocharged