Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
Depends on Serialize schema names in foreign key constraints dolthub/dolt#8461
Fixes
dolt_merge
stomps working set dolthub/doltgresql#855Dolt PR: Fix merge bugs for doltgres dolthub/dolt#8459
While investigating Error on restore into doltgres (pg_restore) dolthub/doltgresql#843, several statements were failing due to double-quoted identifiers. This PR fixes
COPY
statements and use ofnextval()
andsetval()
to properly parse double-quoted identifiers.Adds a GitHub Actions workflow to label PRs from outside the team with the "contribution" label. This is the same workflow we use for dolt/go-mysql-server/etc.
Dolt PR: Fix GetSchema for detached head dolthub/dolt#8434
Fixes
DESCRIBE [table]
does not work for tables in other schemas dolthub/doltgresql#830TEXT
fields in secondary indexes andUNIQUE
constraintsAllows
TEXT
columns in Doltgres to work when used in secondary indexes and in unique constraints. PostgreSQL does not have a concept of prefix lengths and Dolt requires prefix lengths forTEXT
columns. This now works in Doltgres because a new Doltgres analyzer rule implicitly fills in a default prefix length in these cases.Depends on:
Stacked on Support for per-table AS OF clauses dolthub/doltgresql#818
COPY ... DELIMITER
testThis adds support for
CREATE USER
,ALTER USER
, andDROP USER
. This also adds the relatedROLE
statements too, since theUSER
statements are essentially aliases for them. Next step will be to look into persistence and bats testing.The intention here should be to initialize a slice with a capacity of length rather than initializing the length of this slice.
The online demo: https://go.dev/play/p/q1BcVCmvidW
Dolt PR: Clean up table functions, fix
dolt_patch
for doltgres dolthub/dolt#8415depends on: use global parser for engine dolthub/go-mysql-server#2683
schema.table
for table_name columnsDolt PR: Return
schema.table
for table name columns in dolt diff/status tables and functions for doltgres dolthub/dolt#8411e.g.:
This functionality lets us exercise Dolt engine tests that have user variables in them.
ALTER COLUMN TYPE
,DEFAULT
, andNOT NULL
statementsDepends on:
translate
andquote_ident
and addpg_operator
tableAlso:
pg_stat_io
view as it is supported for Postgres versions 16 and later.ALTER TABLE
support forADD COLUMN
,DROP COLUMN
, andRENAME COLUMN
Created by the Release workflow to update DoltgreSQL's version
delimiter
support forCOPY FROM STDIN
Allows the
DELIMITER
copy option to be specified for CSV and TEXT imports.Also adds initial support for the legacy copy option syntax described in the Compatibility section of
COPY
docs (e.g.COPY <table> FROM STDIN CSV, HEADER;
instead ofCOPY <table> FROM STDIN WITH (FORMAT CSV, HEADER true);
).For the most part, this implements the following portions of RFC 5802:
This also bases the stored data from:
This PR finally lets the server do the full authentication routine with the client. For now, I've created a mock database full of mock users, which are actually being tested by all of our engine tests since we do supply a username and password when creating and setting up the server. The
pgx
library is handling the client-side authentication for these tests.The next step is to handle basic
CREATE USER
andDROP USER
statements. With those in, I'll create a full battery of tests (bats tests, unit tests, dedicated engine tests, etc.). Unit tests are not included in this PR since I may make further changes with the next PR, and I'd prefer to do a big testing pass at once since none of this is in production just yet.After the aforementioned statements and testing, I'll move on to designing the storage portion, since the mock user and mock database are stand-ins for an actual implementation.
Closed Issues
dolt_merge
stomps working setDESCRIBE [table]
does not work for tables in other schemasinformation_schema
tables do not work in detached head stateDELIMITER
inCOPY...FROM