Skip to content

fix sqllogictest harness to use float rounding #7426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jycor merged 8 commits into from
Jan 30, 2024
+3 −2
Merged

fix sqllogictest harness to use float rounding #7426

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4e38973
fix sqllogictest harness to truncate instead of round
Jan 29, 2024
f2c4b11
[skip actions] [ga-update-correctness] SQL Correctness updated to 99.…
coffeegoddd Jan 29, 2024
7b40120
they round > .5 not >= .5
Jan 29, 2024
a1ee787
Merge branch 'james/round' of https://github.com/dolthub/dolt into ja…
Jan 29, 2024
0e933ab
use ieee float rounding
Jan 30, 2024
579156b
[skip actions] [ga-update-correctness] SQL Correctness updated to 99.…
coffeegoddd Jan 30, 2024
4847a98
merge with main
Jan 30, 2024
05ee1df
[skip actions] [ga-update-correctness] SQL Correctness updated to 99.…
coffeegoddd Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion go/libraries/doltcore/sqle/logictest/dolt/doltharness.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,8 @@ func toSqlString(val interface{}) string {
return fmt.Sprintf("%.3f", v)
case decimal.Decimal:
// exactly 3 decimal points for floats
return v.StringFixed(3)
res, _ := v.Float64()
return fmt.Sprintf("%.3f", res)
case int:
return strconv.Itoa(v)
case uint:
Expand Down