Conversation
Contributor
Contributor
Contributor
max-hoffman
approved these changes
Jan 30, 2024
Contributor
max-hoffman
left a comment
There was a problem hiding this comment.
lgtm but a test for a query that fails without this would be nice
Contributor
|
@coffeegoddd DOLT
|
|
@coffeegoddd DOLT
|
|
@coffeegoddd DOLT
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we generated the results for MySQL (specifically the float results), we used the golang
fmt.Sprintf('%.3f')string, even for decimal types. Meanwhile, the doltharness was usingdecimal.Round(). There's evidently a difference in the way these two rounding operations work, so we had some failures due to rounding errors.This PR makes it so decimals are rounded the same way floats are, so that results are consistent.