Filter ignored tables from dolt_status and dolt_diff#10529
Merged
Conversation
Contributor
|
@nicktobey DOLT
|
7b0aa6d to
f3de6b7
Compare
Contributor
|
@nicktobey DOLT
|
…a table matches conflicting ignore rules.
Contributor
|
@nicktobey DOLT
|
525065e to
70dc881
Compare
Contributor
|
@nicktobey DOLT
|
fulghum
approved these changes
Feb 19, 2026
Contributor
fulghum
left a comment
There was a problem hiding this comment.
Code looks good. We should add some tests for diff on ignored tables. I didn't see any tests covering that case.
Looks like we're also missing documentation for a few of these Dolt system tables we're using. Could you please add docs for dolt_status_ignored, and dolt_nonlocal_tables.
Contributor
|
@nicktobey DOLT
|
Contributor
|
@nicktobey DOLT
|
|
@coffeegoddd DOLT
|
|
@coffeegoddd DOLT
|
|
@coffeegoddd DOLT
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10524
Ignored tables (tables matching patterns in the dolt_ignore system table) are tables that aren't intended to be staged. We should exclude them from
dolt statusanddolt diffoutput unless specifically requested with flags.There's one questionable part of this PR: how the system tables handle tables that match multiple conflicting patterns. The
dolt statusanddolt diffCLI commands detect this and display a warning, but there's not currently a way for thedolt_statusanddolt_diffsystem tables to signal these conflicts. So with this PR:This PR also removes most of the duplicate logic out of the
dolt statuscommand in favor of thedolt_status_ignoredsystem table. We can't remove all the logic because of the aforemenentioned check.