Merged
Conversation
chenrui333
approved these changes
Feb 21, 2026
Contributor
|
🤖 An automated task has requested bottles to be published to this PR. Caution Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.Details
release notes
Prior to this change pushes that would take ~6s to DoltHub took ~70s to a Git remote. This pr removes fetch for non-manifest keys that are already in the cache on the read path which brings a push to a git remote down to around ~17s. One the write path, tablefiles are now only written to the remote at the same time the manifest is written, in a single commit and push call. This change brings the performance down to about ~8s in my testing. This optimization doesn't change the Blobstore interface, but does introduce a risk for a caller-side bug, by incorrectly calling Put(tf1), CheckAndPut(manifest_referencing_tf1_and_tf2), Put(tf2). This changes the visibility contract that a Put is already on the remote.
Also, fixes git fetch failures caused by stale remote-tracking refs: add --refmap="" so fetch only processes our explicit refspec and ignores the remote's default fetch refspecs, which can fail with ref directory/file conflicts unrelated to our ref.
Currently our workflow for dealing with conflicts in cherry-pick is to
dolt_addthendolt_commitwhich ends up losing commit data like the author and commit message.This PR adds the
--continueflag to cherry-pick (both stored procedure and CLI), which will preserve the commit metadata.This flag exists on
git cherry-pickFixes DOLT_DIFF and DOLT_STATUS should omit newly created tables that match DOLT_IGNORE patterns dolthub/dolt#10524
Ignored tables (tables matching patterns in the dolt_ignore system table) are tables that aren't intended to be staged. We should exclude them from
dolt statusanddolt diffoutput unless specifically requested with flags.There's one questionable part of this PR: how the system tables handle tables that match multiple conflicting patterns. The
dolt statusanddolt diffCLI commands detect this and display a warning, but there's not currently a way for thedolt_statusanddolt_diffsystem tables to signal these conflicts. So with this PR:This PR also removes most of the duplicate logic out of the
dolt statuscommand in favor of thedolt_status_ignoredsystem table. We can't remove all the logic because of the aforemenentioned check.go-mysql-server
ALTER TABLE DROP CONSTRAINTto remove unique indexesWhen adding a unique constraint to a table, it wasn't possible to remove it using
ALTER TABLE DROP CONSTRAINT. This change allows unique indexes to be removed with this syntax.Related to: Fix ALTER TABLE ... DROP CONSTRAINT for UNIQUE constraints dolthub/doltgresql#2359
sql.StringTypeinterface forsystemStringTypefixes dolthub/dolt#10534
part of dolthub/dolt#10535
Closed Issues
View the full release notes at https://github.com/dolthub/dolt/releases/tag/v1.82.4.