Git remote support fixes: shard git blobstore writes and normalize clone/remote URLs#10485
Merged
coffeegoddd merged 4 commits intomainfrom Feb 12, 2026
Merged
Git remote support fixes: shard git blobstore writes and normalize clone/remote URLs#10485coffeegoddd merged 4 commits intomainfrom
coffeegoddd merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes several git-remote workflows by improving git-backed storage defaults, normalizing git remote URLs at add-time, correcting clone directory inference, and adding validation for empty git remotes (with updated/new tests).
Changes:
- Default git blobstore writes to use chunked objects with a 50MiB max part size when not explicitly configured.
- Normalize git remote URLs when storing them (e.g., scp-style SSH →
git+ssh://...) and validate that git remotes have at least one branch. - Fix
clonedirectory inference to strip.gitsuffix and expand test coverage + integration test setup.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| integration-tests/bats/remotes-git.bats | Adds a helper to seed an initial branch on bare git remotes so git-remote integration tests can push reliably. |
| go/store/nbs/store.go | Applies a default MaxPartSize (50MiB) for git-backed stores to enable chunked writes by default. |
| go/store/nbs/git_blobstore_empty_remote_test.go | Adds a test asserting NewGitStore enables chunked writes by default. |
| go/libraries/doltcore/dbfactory/git_remote.go | Adds ErrGitRemoteHasNoBranches and blocks CreateDB for git remotes with no remote branches. |
| go/libraries/doltcore/dbfactory/git_remote_test.go | Seeds a main branch for existing tests and adds a new test for the “no branches” failure. |
| go/cmd/dolt/commands/remote.go | Stores normalized git+* URLs for git remotes when adding via SQL path. |
| go/cmd/dolt/commands/remote_test.go | Adds a unit test for storing normalized git URLs. |
| go/cmd/dolt/commands/clone.go | Strips .git from inferred clone directory names. |
| go/cmd/dolt/commands/clone_test.go | Updates expected inferred dir and adds coverage for git+file://... URL inference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@coffeegoddd DOLT
|
reltuk
approved these changes
Feb 11, 2026
Contributor
Author
|
@coffeegoddd DOLT
|
Contributor
Author
|
@coffeegoddd DOLT
|
Contributor
Author
|
@coffeegoddd DOLT
|
Contributor
Author
|
@coffeegoddd DOLT
|
Contributor
Author
|
@coffeegoddd DOLT
|
Contributor
Author
|
@coffeegoddd DOLT
|
Contributor
Author
|
@coffeegoddd DOLT
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix git-remote workflows by defaulting git-blobstore sharding to 50MB and correcting clone dir inference, SSH remote parsing, and empty-remote validation (with tests).