Add `git+*` dbfactory remotes with required `--git-cache-dir`, `--ref` support, and integration tests by coffeegoddd · Pull Request #10483 · dolthub/dolt

coffeegoddd · 2026-02-11T03:57:06Z

Implements git-backed Dolt remotes via dbfactory (git+file/http/https/ssh), requiring --git-cache-dir and supporting --ref, with end-to-end BATS + Go multi-client coverage for push/clone/pull and empty-remote bootstrap.

coffeegoddd · 2026-02-11T04:10:18Z

@coffeegoddd DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.55	0.55	0.0
groupby_scan	10.09	9.91	-1.78
index_join	1.86	1.82	-2.15
index_join_scan	1.34	1.34	0.0
index_scan	21.89	21.89	0.0
oltp_point_select	0.27	0.27	0.0
oltp_read_only	5.28	5.28	0.0
select_random_points	0.54	0.54	0.0
select_random_ranges	0.56	0.55	-1.79
table_scan	22.28	22.28	0.0
types_table_scan	65.65	66.84	1.81

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.32	6.32	0.0
oltp_insert	3.07	3.07	0.0
oltp_read_write	11.45	11.45	0.0
oltp_update_index	3.25	3.25	0.0
oltp_update_non_index	3.13	3.13	0.0
oltp_write_only	6.09	6.09	0.0
types_delete_insert	6.91	6.79	-1.74

coffeegoddd · 2026-02-11T04:14:09Z

@coffeegoddd DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.55	0.55	0.0
groupby_scan	10.09	9.91	-1.78
index_join	1.82	1.82	0.0
index_join_scan	1.34	1.34	0.0
index_scan	22.28	22.28	0.0
oltp_point_select	0.27	0.27	0.0
oltp_read_only	5.37	5.37	0.0
select_random_points	0.54	0.54	0.0
select_random_ranges	0.55	0.56	1.82
table_scan	22.28	22.28	0.0
types_table_scan	66.84	68.05	1.81

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.32	6.32	0.0
oltp_insert	3.07	3.07	0.0
oltp_read_write	11.45	11.45	0.0
oltp_update_index	3.25	3.25	0.0
oltp_update_non_index	3.19	3.13	-1.88
oltp_write_only	6.09	6.09	0.0
types_delete_insert	6.91	6.91	0.0

coffeegoddd · 2026-02-11T04:26:49Z

@coffeegoddd DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.55	0.55	0.0
groupby_scan	10.09	9.91	-1.78
index_join	1.82	1.86	2.2
index_join_scan	1.34	1.34	0.0
index_scan	22.28	21.89	-1.75
oltp_point_select	0.27	0.28	3.7
oltp_read_only	5.28	5.37	1.7
select_random_points	0.54	0.54	0.0
select_random_ranges	0.55	0.55	0.0
table_scan	22.28	22.28	0.0
types_table_scan	66.84	66.84	0.0

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.32	6.32	0.0
oltp_insert	3.07	3.07	0.0
oltp_read_write	11.45	11.45	0.0
oltp_update_index	3.19	3.19	0.0
oltp_update_non_index	3.13	3.13	0.0
oltp_write_only	6.09	6.09	0.0
types_delete_insert	6.79	6.91	1.77

coffeegoddd · 2026-02-11T04:32:44Z

@coffeegoddd DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.55	0.55	0.0
groupby_scan	9.91	9.91	0.0
index_join	1.82	1.86	2.2
index_join_scan	1.34	1.32	-1.49
index_scan	21.89	21.5	-1.78
oltp_point_select	0.27	0.27	0.0
oltp_read_only	5.37	5.28	-1.68
select_random_points	0.54	0.54	0.0
select_random_ranges	0.56	0.55	-1.79
table_scan	21.89	21.89	0.0
types_table_scan	65.65	66.84	1.81

write_tests	from_latency	to_latency
oltp_delete_insert	6.32	6.32
oltp_insert	3.07	3.07
oltp_read_write	11.45	11.45
oltp_update_index	3.19	3.19
oltp_update_non_index	3.13	3.13
oltp_write_only	6.09	6.09
types_delete_insert	6.79	6.79

coffeegoddd · 2026-02-11T04:33:03Z

@coffeegoddd DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	63.32	63.32	0.0

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	`86ca603`	36.71	dolt	`05a68ac`	36.56	-0.41

coffeegoddd · 2026-02-11T04:36:07Z

@coffeegoddd DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	62.19	61.08	-1.78

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	`86ca603`	37.57	dolt	`5a012bf`	37.52	-0.13

coffeegoddd · 2026-02-11T04:42:45Z

@coffeegoddd DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.55	0.55	0.0
groupby_scan	9.91	9.91	0.0
index_join	1.82	1.82	0.0
index_join_scan	1.34	1.34	0.0
index_scan	21.89	21.89	0.0
oltp_point_select	0.27	0.27	0.0
oltp_read_only	5.28	5.37	1.7
select_random_points	0.53	0.53	0.0
select_random_ranges	0.55	0.55	0.0
table_scan	22.28	21.89	-1.75
types_table_scan	66.84	66.84	0.0

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.32	6.32	0.0
oltp_insert	3.07	3.07	0.0
oltp_read_write	11.45	11.45	0.0
oltp_update_index	3.19	3.19	0.0
oltp_update_non_index	3.13	3.13	0.0
oltp_write_only	6.09	6.09	0.0
types_delete_insert	6.91	6.79	-1.74

coffeegoddd · 2026-02-11T04:48:44Z

@coffeegoddd DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	62.19	62.19	0.0

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	`86ca603`	36.82	dolt	`76881c2`	37.32	1.36

coffeegoddd · 2026-02-11T04:53:15Z

@coffeegoddd DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.55	0.55	0.0
groupby_scan	10.09	9.91	-1.78
index_join	1.82	1.82	0.0
index_join_scan	1.34	1.34	0.0
index_scan	22.28	21.89	-1.75
oltp_point_select	0.27	0.27	0.0
oltp_read_only	5.37	5.37	0.0
select_random_points	0.54	0.54	0.0
select_random_ranges	0.56	0.56	0.0
table_scan	22.28	21.89	-1.75
types_table_scan	66.84	66.84	0.0

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.32	6.32	0.0
oltp_insert	3.07	3.07	0.0
oltp_read_write	11.45	11.45	0.0
oltp_update_index	3.19	3.19	0.0
oltp_update_non_index	3.13	3.13	0.0
oltp_write_only	6.09	6.09	0.0
types_delete_insert	6.91	6.79	-1.74

coffeegoddd · 2026-02-11T04:54:47Z

@coffeegoddd DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	62.19	61.08	-1.78

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	`86ca603`	36.96	dolt	`6432b22`	37.42	1.24

Copilot

Pull request overview

Adds Git-backed Dolt remotes via dbfactory using git+* URL schemes, wiring support through CLI + SQL procedures and validating behavior with new end-to-end and unit tests.

Changes:

Introduce a GitRemoteFactory (git+file/http/https/ssh) with local bare-repo caching and configurable git_ref.
Normalize common git remote strings (scp-style, schemeless host/path, .git URLs, local paths) into canonical git+* URLs.
Add --git-cache-dir / --ref plumbing across CLI commands + SQL procedures, plus BATS + Go tests for push/clone/pull and empty-remote bootstrap.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
integration-tests/bats/sql-remotes-git.bats	SQL procedure integration tests for `--ref` behavior on git remotes.
integration-tests/bats/remotes-git.bats	End-to-end git remote smoke tests (push/clone/pull) + bootstrap + default cache-dir behavior.
go/libraries/doltcore/sqle/dprocedures/dolt_remote.go	Adds git remote parameter support to `dolt_remote('add', ...)`.
go/libraries/doltcore/sqle/dprocedures/dolt_clone.go	Adds git remote parameter support + URL normalization fallback for SQL `dolt_clone`.
go/libraries/doltcore/sqle/dprocedures/dolt_backup.go	Adds git remote parameter handling to backup URL parsing.
go/libraries/doltcore/env/remotes.go	Plumbs remote name into git-remote params; normalizes git URLs inside `GetAbsRemoteUrl`.
go/libraries/doltcore/env/git_remote_url.go	New URL normalization helper for recognizing/rewriting git remote strings.
go/libraries/doltcore/env/git_remote_url_test.go	Unit tests for `NormalizeGitRemoteUrl`.
go/libraries/doltcore/dbfactory/git_remote.go	New `GitRemoteFactory` implementation (cache repo + git remote config + NBS Git store).
go/libraries/doltcore/dbfactory/git_remote_test.go	Go tests validating cache dir usage and multi-client roundtrip.
go/libraries/doltcore/dbfactory/factory.go	Registers `git+*` schemes in the dbfactory map.
go/cmd/dolt/commands/remote.go	Adds `--git-cache-dir` / `--ref` parsing and scheme gating for CLI `dolt remote`.
go/cmd/dolt/commands/remote_test.go	Tests for git remote flag parsing.
go/cmd/dolt/commands/read_tables.go	Adds git flags to arg parser and URL normalization fallback for `read-tables`.
go/cmd/dolt/commands/read_tables_test.go	Verifies `read-tables` parser accepts git flags.
go/cmd/dolt/commands/clone.go	Adds URL normalization fallback during clone arg parsing.
go/cmd/dolt/commands/clone_test.go	Tests clone directory inference behavior.
go/cmd/dolt/cli/arg_parser_helpers.go	Adds git flags to clone/remote/backup arg parsers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

go/libraries/doltcore/sqle/dprocedures/dolt_remote.go

Copilot · 2026-02-11T05:03:07Z

go/libraries/doltcore/sqle/dprocedures/dolt_clone.go

+		if ref != "" {
+			if !isGitRemote {
+				return nil, errhand.BuildDError("error: --ref is only supported for git remotes").Build()
+			}
+			remoteParms[dbfactory.GitRefParam] = ref
+		}


The --ref flag handling treats an empty value as "not provided" (no error). In other interfaces (e.g. dolt remote add), an empty --ref is rejected. Consider making this consistent by erroring if --ref is present but empty, instead of silently ignoring it.

Suggested change

if ref != "" {

if !isGitRemote {

return nil, errhand.BuildDError("error: --ref is only supported for git remotes").Build()

}

remoteParms[dbfactory.GitRefParam] = ref

}

if ref == "" {

return nil, errhand.BuildDError("error: --ref cannot be empty").Build()

}

if !isGitRemote {

return nil, errhand.BuildDError("error: --ref is only supported for git remotes").Build()

}

remoteParms[dbfactory.GitRefParam] = ref

go/libraries/doltcore/dbfactory/git_remote.go

Copilot · 2026-02-11T05:03:07Z

go/libraries/doltcore/env/git_remote_url.go

+}
+
+func looksLikeLocalPath(s string) bool {
+	return strings.HasPrefix(s, "/") || strings.HasPrefix(s, "./") || strings.HasPrefix(s, "../")


looksLikeLocalPath() only checks for '/', './', and '../' prefixes. On Windows, absolute paths like "C:\repos\remote.git" (or UNC paths) won't be treated as local paths, so NormalizeGitRemoteUrl will misclassify them as schemeless host/path and return a git+https URL. Consider using filepath.IsAbs / filepath.VolumeName (and UNC checks) to detect Windows absolute paths reliably.

Suggested change

return strings.HasPrefix(s, "/") || strings.HasPrefix(s, "./") || strings.HasPrefix(s, "../")

if s == "" {

return false

}

// Use filepath.IsAbs so that absolute paths are detected according to the

// current OS semantics (e.g. "C:\repo" on Windows, "/repo" on POSIX).

if filepath.IsAbs(s) {

return true

}

// Preserve existing behavior for common relative path prefixes.

if strings.HasPrefix(s, "./") || strings.HasPrefix(s, "../") {

return true

}

// Be robust for UNC-like paths even when running on non-Windows systems.

// UNC paths typically start with "\\" or "//".

if strings.HasPrefix(s, `\\`) || strings.HasPrefix(s, "//") {

return true

}

return false

go/libraries/doltcore/dbfactory/git_remote.go

go/libraries/doltcore/sqle/dprocedures/dolt_backup.go

coffeegoddd · 2026-02-11T05:04:47Z

@coffeegoddd DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	61.08	62.19	1.82

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	`86ca603`	37.38	dolt	`815b950`	37.31	-0.19

coffeegoddd · 2026-02-11T05:08:15Z

@coffeegoddd DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.55	0.55	0.0
groupby_scan	10.09	9.91	-1.78
index_join	1.82	1.79	-1.65
index_join_scan	1.34	1.34	0.0
index_scan	21.89	21.89	0.0
oltp_point_select	0.27	0.28	3.7
oltp_read_only	5.28	5.37	1.7
select_random_points	0.54	0.54	0.0
select_random_ranges	0.55	0.55	0.0
table_scan	22.28	21.89	-1.75
types_table_scan	65.65	66.84	1.81

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.32	6.32	0.0
oltp_insert	3.07	3.07	0.0
oltp_read_write	11.45	11.45	0.0
oltp_update_index	3.25	3.19	-1.85
oltp_update_non_index	3.13	3.13	0.0
oltp_write_only	6.09	6.09	0.0
types_delete_insert	6.91	6.79	-1.74

coffeegoddd · 2026-02-11T05:44:34Z

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`554ef83`	ok	5937471

version	total_tests
`554ef83`	5937471

correctness_percentage
100.0

coffeegoddd · 2026-02-11T05:52:26Z

@coffeegoddd DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	61.08	61.08	0.0

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	`86ca603`	37.48	dolt	`554ef83`	37.41	-0.19

coffeegoddd · 2026-02-11T18:24:37Z

@coffeegoddd DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.54	0.54	0.0
groupby_scan	9.91	9.91	0.0
index_join	1.82	1.82	0.0
index_join_scan	1.34	1.34	0.0
index_scan	22.28	21.89	-1.75
oltp_point_select	0.28	0.27	-3.57
oltp_read_only	5.28	5.37	1.7
select_random_points	0.53	0.54	1.89
select_random_ranges	0.56	0.55	-1.79
table_scan	22.28	21.89	-1.75
types_table_scan	66.84	65.65	-1.78

write_tests	from_latency	to_latency
oltp_delete_insert	6.32	6.32
oltp_insert	3.07	3.07
oltp_read_write	11.45	11.45
oltp_update_index	3.19	3.19
oltp_update_non_index	3.13	3.13
oltp_write_only	6.09	6.09
types_delete_insert	6.79	6.79

coffeegoddd · 2026-02-11T18:33:38Z

@coffeegoddd DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.54	0.54	0.0
groupby_scan	10.09	9.91	-1.78
index_join	1.82	1.82	0.0
index_join_scan	1.34	1.34	0.0
index_scan	22.28	21.89	-1.75
oltp_point_select	0.27	0.27	0.0
oltp_read_only	5.28	5.28	0.0
select_random_points	0.54	0.54	0.0
select_random_ranges	0.55	0.55	0.0
table_scan	22.28	21.89	-1.75
types_table_scan	65.65	65.65	0.0

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.32	6.32	0.0
oltp_insert	3.07	3.07	0.0
oltp_read_write	11.45	11.45	0.0
oltp_update_index	3.19	3.19	0.0
oltp_update_non_index	3.13	3.13	0.0
oltp_write_only	6.09	6.09	0.0
types_delete_insert	6.79	6.91	1.77

reltuk

LGTM. A couple comments on bats test.

I reached out on Discord regarding git remote name and an inconsistency in behavior between multi Dolt repositories using the same remote name and same cache dir vs. a single Dolt repository using multiple remotes with different names and the same remote url. We should sync up on approach there as well.

I'm working on landing updates to lambdabats so it has git available.

integration-tests/bats/remotes-git.bats

integration-tests/bats/sql-remotes-git.bats

coffeegoddd · 2026-02-11T18:46:45Z

@coffeegoddd DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	61.08	61.08	0.0

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	`86ca603`	37.72	dolt	`36b1853`	37.57	-0.4

coffeegoddd · 2026-02-11T18:48:07Z

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`ae5544d`	ok	5937471

version	total_tests
`ae5544d`	5937471

correctness_percentage
100.0

coffeegoddd · 2026-02-11T18:55:51Z

@coffeegoddd DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	61.08	61.08	0.0

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	`86ca603`	37.84	dolt	`ae5544d`	38.19	0.92

coffeegoddd · 2026-02-11T20:07:37Z

@coffeegoddd DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.55	0.56	1.82
groupby_scan	9.91	9.91	0.0
index_join	1.82	1.86	2.2
index_join_scan	1.34	1.37	2.24
index_scan	22.28	21.89	-1.75
oltp_point_select	0.28	0.27	-3.57
oltp_read_only	5.37	5.37	0.0
select_random_points	0.54	0.54	0.0
select_random_ranges	0.56	0.55	-1.79
table_scan	22.28	21.89	-1.75
types_table_scan	66.84	66.84	0.0

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.32	6.32	0.0
oltp_insert	3.07	3.07	0.0
oltp_read_write	11.45	11.45	0.0
oltp_update_index	3.19	3.19	0.0
oltp_update_non_index	3.13	3.13	0.0
oltp_write_only	6.09	6.09	0.0
types_delete_insert	6.79	6.91	1.77

coffeegoddd · 2026-02-11T20:12:08Z

@coffeegoddd DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.55	0.56	1.82
groupby_scan	10.09	10.09	0.0
index_join	1.86	1.86	0.0
index_join_scan	1.37	1.37	0.0
index_scan	22.28	22.28	0.0
oltp_point_select	0.27	0.27	0.0
oltp_read_only	5.28	5.37	1.7
select_random_points	0.54	0.54	0.0
select_random_ranges	0.55	0.55	0.0
table_scan	22.28	22.69	1.84
types_table_scan	68.05	68.05	0.0

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.32	6.32	0.0
oltp_insert	3.07	3.07	0.0
oltp_read_write	11.45	11.45	0.0
oltp_update_index	3.19	3.25	1.88
oltp_update_non_index	3.13	3.19	1.92
oltp_write_only	6.09	6.09	0.0
types_delete_insert	6.91	6.91	0.0

coffeegoddd · 2026-02-11T20:28:02Z

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`ce10f62`	ok	5937471

version	total_tests
`ce10f62`	5937471

correctness_percentage
100.0

coffeegoddd · 2026-02-11T20:31:05Z

@coffeegoddd DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	61.08	61.08	0.0

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	`86ca603`	37.83	dolt	`027fd3e`	37.69	-0.37

coffeegoddd · 2026-02-11T20:34:12Z

@coffeegoddd DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	62.19	62.19	0.0

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	`86ca603`	37.43	dolt	`ce10f62`	36.86	-1.52

coffeegoddd · 2026-02-11T21:00:44Z

@coffeegoddd DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.55	0.55	0.0
groupby_scan	10.09	9.91	-1.78
index_join	1.82	1.86	2.2
index_join_scan	1.34	1.37	2.24
index_scan	22.28	22.28	0.0
oltp_point_select	0.27	0.28	3.7
oltp_read_only	5.37	5.37	0.0
select_random_points	0.54	0.54	0.0
select_random_ranges	0.55	0.55	0.0
table_scan	22.28	22.28	0.0
types_table_scan	65.65	66.84	1.81

write_tests	from_latency	to_latency
oltp_delete_insert	6.32	6.32
oltp_insert	3.07	3.07
oltp_read_write	11.45	11.45
oltp_update_index	3.19	3.19
oltp_update_non_index	3.13	3.13
oltp_write_only	6.09	6.09
types_delete_insert	6.91	6.91

github-actions · 2026-02-11T21:00:54Z

This PR is being tested for performance. Please allow ~12 mins for this to complete. If this PR does not result in a performance regression, the performance_approved label will be automatically added to this PR.

coffeegoddd · 2026-02-11T21:17:13Z

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`3b2ff8c`	ok	5937471

version	total_tests
`3b2ff8c`	5937471

correctness_percentage
100.0

coffeegoddd · 2026-02-11T21:23:56Z

@coffeegoddd DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	62.19	62.19	0.0

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	`86ca603`	37.28	dolt	`3b2ff8c`	37.18	-0.27

coffeegoddd added 6 commits February 10, 2026 18:48

/go/{cmd,libraries}: dbfactory stuff and url stuff

a33f7cb

/go/{cmd,libraries}: wip

b262057

/go/{cmd,libraries}: make ref an argument

c431af3

/go/{cmd,libraries}: more fixes

9a70ea0

/{go,integration-tests}: add tests

05a68ac

/go/cmd/dolt/commands: update clone

5a012bf

coffeegoddd added the performance_approved label Feb 11, 2026

coffeegoddd added 2 commits February 10, 2026 20:14

/{go,integration-tests}: fixes

76881c2

/go/libraries/doltcore/dbfactory: cleanup

6432b22

coffeegoddd removed the performance_approved label Feb 11, 2026

/go/{cmd, libraries}: some cleanup

815b950

coffeegoddd added the performance_approved label Feb 11, 2026

/go/libraries/doltcore/sqle/dprocedures: refactor

b909f50

/go/libraries/doltcore/dbfactory: fix windows

07cad4b

coffeegoddd requested a review from Copilot February 11, 2026 04:56

Copilot started reviewing on behalf of coffeegoddd February 11, 2026 04:56 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

coffeegoddd removed the performance_approved label Feb 11, 2026

coffeegoddd added the correctness_approved label Feb 11, 2026

coffeegoddd added 2 commits February 11, 2026 10:11

/go/{cmd,libraries}: remote git dir arg

36b1853

/go/cmd/dolt/{cli, commands}: fix usage line

ae5544d

reltuk approved these changes Feb 11, 2026

View reviewed changes

integration-tests/bats/remotes-git.bats Outdated Show resolved Hide resolved

integration-tests/bats/remotes-git.bats Outdated Show resolved Hide resolved

integration-tests/bats/sql-remotes-git.bats Outdated Show resolved Hide resolved

coffeegoddd added 4 commits February 11, 2026 11:45

/{go, integration-tests}: fix repo cache

e64f8d8

/integration-tests: fix tests

f2e26ce

/{go,integration-tests}: some fixes and cleanup

027fd3e

/integration-tests: more cleanup

ce10f62

/go/libraries/doltcore/env: fix bats maybe

3b2ff8c

coffeegoddd removed the performance_approved label Feb 11, 2026

coffeegoddd added the performance_approved label Feb 11, 2026

coffeegoddd merged commit 3c2969b into main Feb 11, 2026
28 of 29 checks passed

coffeegoddd deleted the db/dbfactory branch February 11, 2026 21:25

BrewTestBot mentioned this pull request Feb 12, 2026

dolt 1.81.8 Homebrew/homebrew-core#267088

Merged

-	return strings.HasPrefix(s, "/") || strings.HasPrefix(s, "./") || strings.HasPrefix(s, "../")
+	if s == "" {
+		return false
+	}
+	// Use filepath.IsAbs so that absolute paths are detected according to the
+	// current OS semantics (e.g. "C:\repo" on Windows, "/repo" on POSIX).
+	if filepath.IsAbs(s) {
+		return true
+	}
+	// Preserve existing behavior for common relative path prefixes.
+	if strings.HasPrefix(s, "./") || strings.HasPrefix(s, "../") {
+		return true
+	}
+	// Be robust for UNC-like paths even when running on non-Windows systems.
+	// UNC paths typically start with "\\" or "//".
+	if strings.HasPrefix(s, `\\`) || strings.HasPrefix(s, "//") {
+		return true
+	}
+	return false

Uh oh!

Conversation

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

reltuk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026

Uh oh!

coffeegoddd commented Feb 11, 2026