Add class-string typehint for getAssociationTargetClass#163
Merged
greg0ire merged 3 commits intodoctrine:2.2.xfrom Apr 5, 2021
VincentLanglet:patch-2
Merged
Add class-string typehint for getAssociationTargetClass#163greg0ire merged 3 commits intodoctrine:2.2.xfrom VincentLanglet:patch-2
greg0ire merged 3 commits intodoctrine:2.2.xfrom
VincentLanglet:patch-2
Conversation
Remove unnecessary github actions branch filters
This was referenced Apr 4, 2021
Contributor
Author
|
Friendly ping @greg0ire :) |
Member
|
🤔 why are you targeting 2.1.x ? |
Contributor
Author
It was the default branch, and I don't know the rules about the phpdoc. You prefer 2.2.x ? |
Member
|
I think 2.2.x is appropriate indeed 👍 . Your proposal is more precise, but |
Contributor
Author
|
Done |
greg0ire
approved these changes
Apr 5, 2021
Member
|
Thanks @VincentLanglet ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.