Fix phpdoc of ClassMetadataInfo::getIdentifierValues#8590
Merged
greg0ire merged 1 commit intodoctrine:2.8.xfrom Apr 4, 2021
VincentLanglet:patch-2
Merged
Fix phpdoc of ClassMetadataInfo::getIdentifierValues#8590greg0ire merged 1 commit intodoctrine:2.8.xfrom VincentLanglet:patch-2
greg0ire merged 1 commit intodoctrine:2.8.xfrom
VincentLanglet:patch-2
Conversation
greg0ire
approved these changes
Apr 4, 2021
Member
|
Thanks @VincentLanglet ! |
Contributor
Author
|
Thanks, if you have some time, please take a look at doctrine/persistence#163 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @greg0ire, this will fixed a psalm issue from SonataDoctrineORM ;)
The keys of the returned array are the values of
$this->identifierwhich is astring[].So
array<string|int, mixed>should bearray<string, mixed>