Apply Doctrine CS 5.0

bin/doctrine-migrations.php

@@ -17,7 +17,7 @@
 use function is_readable;
 use function trigger_error;
 
-(function () : void {
+(static function () : void {
     $autoloadFiles = [
         __DIR__ . '/../vendor/autoload.php',
         __DIR__ . '/../../../autoload.php',

composer.json

@@ -20,7 +20,7 @@
     },
     "require-dev": {
         "ext-pdo_sqlite": "*",
-        "doctrine/coding-standard": "^4.0",
+        "doctrine/coding-standard": "^5.0",
         "doctrine/orm": "^2.6",
         "jdorn/sql-formatter": "^1.1",
         "mikey179/vfsStream": "^1.6",

lib/Doctrine/Migrations/Configuration/AbstractFileConfiguration.php

@@ -22,7 +22,6 @@
  */
 abstract class AbstractFileConfiguration extends Configuration
 {
-    /** @var array */
     private const ALLOWED_CONFIGURATION_KEYS = [
         'migrations_namespace',
         'table_name',
@@ -111,7 +110,7 @@ protected function getDirectoryRelativeToFile(string $file, string $input) : str
     {
         $path = realpath(dirname($file) . '/' . $input);
 
-        return ($path !== false) ? $path : $input;
+        return $path !== false ? $path : $input;
     }
 
     /**

lib/Doctrine/Migrations/Configuration/Connection/Loader/ArrayConnectionConfigurationLoader.php

@@ -19,7 +19,7 @@
  */
 class ArrayConnectionConfigurationLoader implements ConnectionLoaderInterface
 {
-    /** @var null|string */
+    /** @var string|null */
     private $filename;
 
     public function __construct(?string $filename)

lib/Doctrine/Migrations/Configuration/Connection/Loader/ConnectionConfigurationLoader.php

@@ -16,7 +16,7 @@
  */
 class ConnectionConfigurationLoader implements ConnectionLoaderInterface
 {
-    /** @var null|Configuration */
+    /** @var Configuration|null */
     private $configuration;
 
     public function __construct(?Configuration $configuration = null)

lib/Doctrine/Migrations/DependencyFactory.php

@@ -180,7 +180,7 @@ public function getQueryWriter() : FileQueryWriter
 
     public function getOutputWriter() : OutputWriter
     {
-        return $this->getDependency(OutputWriter::class, function () : OutputWriter {
+        return $this->getDependency(OutputWriter::class, static function () : OutputWriter {
             return new OutputWriter();
         });
     }
@@ -203,7 +203,7 @@ public function getMigrationPlanCalculator() : MigrationPlanCalculator
 
     public function getRecursiveRegexFinder() : RecursiveRegexFinder
     {
-        return $this->getDependency(RecursiveRegexFinder::class, function () : RecursiveRegexFinder {
+        return $this->getDependency(RecursiveRegexFinder::class, static function () : RecursiveRegexFinder {
             return new RecursiveRegexFinder();
         });
     }
@@ -249,7 +249,7 @@ public function getMigrator() : Migrator
 
     public function getStopwatch() : Stopwatch
     {
-        return $this->getDependency(Stopwatch::class, function () : Stopwatch {
+        return $this->getDependency(Stopwatch::class, static function () : Stopwatch {
             $symfonyStopwatch = new SymfonyStopwatch(true);
 
             return new Stopwatch($symfonyStopwatch);

lib/Doctrine/Migrations/FileQueryWriter.php

@@ -18,7 +18,7 @@
  */
 final class FileQueryWriter implements QueryWriter
 {
-    /** @var null|OutputWriter */
+    /** @var OutputWriter|null */
     private $outputWriter;
 
     /** @var FileBuilder */
@@ -60,8 +60,8 @@ public function write(
     private function buildMigrationFilePath(string $path, DateTimeInterface $now) : string
     {
         if (is_dir($path)) {
-            $path = realpath($path);
-            $path = $path . '/doctrine_migration_' . $now->format('YmdHis') . '.sql';
+            $path  = realpath($path);
+            $path .= '/doctrine_migration_' . $now->format('YmdHis') . '.sql';
         }
 
         return $path;

lib/Doctrine/Migrations/Finder/Finder.php

@@ -84,6 +84,7 @@ protected function loadMigrations(array $files, ?string $namespace) : array
      *
      * @param string[]    $files     The set of files that were `required`
      * @param string|null $namespace If not null only classes in this namespace will be returned
+     *
      * @return ReflectionClass[] the classes in `$files`
      */
     protected function loadMigrationClasses(array $files, ?string $namespace) : array

lib/Doctrine/Migrations/Finder/MigrationFinder.php

@@ -12,6 +12,7 @@ interface MigrationFinder
     /**
      * @param string      $directory The directory which the finder should search
      * @param string|null $namespace If not null only classes in this namespace will be returned
+     *
      * @return string[]
      */
     public function findMigrations(string $directory, ?string $namespace = null) : array;

lib/Doctrine/Migrations/Migrator.php

@@ -85,9 +85,9 @@ public function writeSqlFile(string $path, ?string $to = null) : bool
     }
 
     /**
-     * @throws MigrationException
-     *
      * @return string[][]
+     *
+     * @throws MigrationException
      */
     public function migrate(
         ?string $to = null,

lib/Doctrine/Migrations/MigratorConfiguration.php

@@ -7,10 +7,10 @@
 /**
  * The MigratorConfiguration class is responsible for defining the configuration for a migration.
  *
+ * @internal
+ *
  * @see Doctrine\Migrations\Migrator
  * @see Doctrine\Migrations\Version\Executor
- *
- * @internal
  */
 class MigratorConfiguration
 {

lib/Doctrine/Migrations/OutputWriter.php

@@ -15,7 +15,7 @@ class OutputWriter
     public function __construct(?callable $callback = null)
     {
         if ($callback === null) {
-            $callback = function ($message) : void {
+            $callback = static function ($message) : void {
             };
         }
 

lib/Doctrine/Migrations/ParameterFormatterInterface.php

@@ -8,9 +8,9 @@
  * The ParameterFormatterInterface defines the interface for formatting SQL query parameters to a string
  * for display output.
  *
- * @see Doctrine\Migrations\ParameterFormatter
- *
  * @internal
+ *
+ * @see Doctrine\Migrations\ParameterFormatter
  */
 interface ParameterFormatterInterface
 {

lib/Doctrine/Migrations/Provider/LazySchemaDiffProvider.php

@@ -48,7 +48,7 @@ public function createFromSchema() : Schema
 
         return $this->proxyFactory->createProxy(
             Schema::class,
-            function (&$wrappedObject, $proxy, $method, array $parameters, &$initializer) use ($originalSchemaManipulator) {
+            static function (&$wrappedObject, $proxy, $method, array $parameters, &$initializer) use ($originalSchemaManipulator) {
                 $initializer   = null;
                 $wrappedObject = $originalSchemaManipulator->createFromSchema();
 
@@ -64,7 +64,7 @@ public function createToSchema(Schema $fromSchema) : Schema
         if ($fromSchema instanceof LazyLoadingInterface && ! $fromSchema->isProxyInitialized()) {
             return $this->proxyFactory->createProxy(
                 Schema::class,
-                function (& $wrappedObject, $proxy, $method, array $parameters, & $initializer) use ($originalSchemaManipulator, $fromSchema) {
+                static function (& $wrappedObject, $proxy, $method, array $parameters, & $initializer) use ($originalSchemaManipulator, $fromSchema) {
                     $initializer   = null;
                     $wrappedObject = $originalSchemaManipulator->createToSchema($fromSchema);
 

lib/Doctrine/Migrations/Provider/SchemaDiffProvider.php

@@ -14,9 +14,9 @@
  * so that you can manipulate the Schema object. Your manipulated Schema object is then compared to the original Schema
  * object to produce the SQL statements that need to be executed.
  *
- * @see Doctrine\Migrations\Version\Executor
- *
  * @internal
+ *
+ * @see Doctrine\Migrations\Version\Executor
  */
 class SchemaDiffProvider implements SchemaDiffProviderInterface
 {

lib/Doctrine/Migrations/Rollup.php

@@ -16,9 +16,9 @@
  * The Rollup class is responsible for deleting all previously executed migrations from the versions table
  * and marking the freshly dumped schema migration (that was created with SchemaDumper) as migrated.
  *
- * @see Doctrine\Migrations\SchemaDumper
- *
  * @internal
+ *
+ * @see Doctrine\Migrations\SchemaDumper
  */
 class Rollup
 {

lib/Doctrine/Migrations/SchemaDumper.php

@@ -16,9 +16,9 @@
  * The SchemaDumper class is responsible for dumping the current state of your database schema to a migration. This
  * is to be used in conjunction with the Rollup class.
  *
- * @see Doctrine\Migrations\Rollup
- *
  * @internal
+ *
+ * @see Doctrine\Migrations\Rollup
  */
 class SchemaDumper
 {

lib/Doctrine/Migrations/Tools/BooleanStringFormatter.php

@@ -10,9 +10,9 @@
  * The BooleanStringFormatter class is responsible for formatting a string boolean representation to a PHP boolean value.
  * It is used in the XmlConfiguration class to convert the string XML boolean value to a PHP boolean value.
  *
- * @see Doctrine\Migrations\Configuration\XmlConfiguration
- *
  * @internal
+ *
+ * @see Doctrine\Migrations\Configuration\XmlConfiguration
  */
 class BooleanStringFormatter
 {

lib/Doctrine/Migrations/Tools/Console/Command/AbstractCommand.php

@@ -123,7 +123,7 @@ protected function getMigrationConfiguration(
             $this->migrationConfiguration = $configHelper->getMigrationConfig($input);
 
             $this->migrationConfiguration->getOutputWriter()->setCallback(
-                function (string $message) use ($output) : void {
+                static function (string $message) use ($output) : void {
                     $output->writeln($message);
                 }
             );

lib/Doctrine/Migrations/Tools/Console/Command/DiffCommand.php

@@ -20,7 +20,7 @@
  */
 class DiffCommand extends AbstractCommand
 {
-    /** @var null|SchemaProviderInterface */
+    /** @var SchemaProviderInterface|null */
     protected $schemaProvider;
 
     public function __construct(?SchemaProviderInterface $schemaProvider = null)
@@ -72,8 +72,7 @@ protected function configure() : void
                 InputOption::VALUE_OPTIONAL,
                 'Max line length of unformatted lines.',
                 120
-            )
-        ;
+            );
     }
 
     /**