Conversation
Contributor
Majkl578
commented
Sep 25, 2018
Majkl578
commented
| Q | A |
|---|---|
| Type | improvement |
| BC Break | no |
alcaeus
approved these changes
Sep 25, 2018
| 120 | ||
| ) | ||
| ; | ||
| ); |
Member
There was a problem hiding this comment.
Out of curiosity, is this change due to a rule?
| $process = new Process($runDoctrinePharCommand); | ||
|
|
||
| $process->start(function ($type, $buffer) use (&$output, &$successful) : void { | ||
| $process->start(static function ($type, $buffer) use ($successful) : void { |
Member
There was a problem hiding this comment.
Does this still work with $successful not being used by reference?
Contributor
Author
There was a problem hiding this comment.
Well spotted, I missed this one. Looks like a bug, will investigate once back on PC.
Contributor
Author
There was a problem hiding this comment.
Fixer bug reported here: slevomat/coding-standard#500, fixed fix manually.
Also removed unused $buffer which was not detected by any sniff. :/
Member
|
Should we get #749 merged? |
Contributor
Author
|
Let's do this one first, I'll then rebase #749. |
jwage
approved these changes
Sep 25, 2018
Member
|
You da man 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.