Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust PHPStan settings for ORM 3 and DBAL 4 #1404

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Mar 1, 2024

Q A
Type improvement
BC Break no
Fixed issues N/A

Summary

Since the release of ORM 3, the PHPStan analysis is run with ORM 3 and DBAL 4 installed which leads to different errors that need to be ignored. This PR should give us a green CI again.

@derrabus derrabus added this to the 3.7.3 milestone Mar 1, 2024
@derrabus derrabus requested a review from greg0ire March 1, 2024 11:45
@derrabus derrabus merged commit 833189d into doctrine:3.7.x Mar 1, 2024
2 checks passed
@derrabus derrabus deleted the improvement/phpstan-on-dbal-4 branch March 1, 2024 11:49
derrabus added a commit that referenced this pull request Mar 1, 2024
* 3.7.x:
  Adjust PHPStan settings for ORM 3 and DBAL 4 (#1404)
derrabus added a commit to derrabus/migrations that referenced this pull request Mar 1, 2024
* 3.8.x:
  Adjust PHPStan settings for ORM 3 and DBAL 4 (doctrine#1404)
  Flatten directory tree
  Switch to attributes in docs (doctrine#1392)
  chore: Add missing option in MigrateCommand help section
  ci: fix variable reference (doctrine#1385)
  Fix formatParameter() for boolean (doctrine#1377)
  doctrineGH-1379: Improve Deprecation thrown check + logic
  Updated documentation for config-cli.php file according to v3.7.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants