Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatParameter() for boolean #1377

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Fix formatParameter() for boolean #1377

merged 1 commit into from
Dec 11, 2023

Conversation

jderusse
Copy link
Contributor

Q A
Type bug
BC Break yes
Fixed issues n/a

Summary

This PR fixes BC break when formatting a boolean parameters (and type is not defined)

        $this->addSql('INSERT INTO XXX (..., is_bar) VALUES (..., :is_bar)', [
            'is_bar' => true,
        ]);

@jderusse
Copy link
Contributor Author

friendly reminder

@derrabus derrabus added this to the 3.7.3 milestone Dec 11, 2023
@derrabus derrabus added the Bug label Dec 11, 2023
@derrabus derrabus merged commit 7be8220 into doctrine:3.7.x Dec 11, 2023
11 checks passed
@derrabus
Copy link
Member

Thank you!

@jderusse jderusse deleted the fix/format-bool branch December 11, 2023 11:08
derrabus added a commit to derrabus/migrations that referenced this pull request Mar 1, 2024
@derrabus
Merge branch '3.8.x' into 4.0.x
ba12f52 
* 3.8.x:
  Flatten directory tree
  Switch to attributes in docs (doctrine#1392)
  chore: Add missing option in MigrateCommand help section
  ci: fix variable reference (doctrine#1385)
  Fix formatParameter() for boolean (doctrine#1377)
  doctrineGH-1379: Improve Deprecation thrown check + logic
  Updated documentation for config-cli.php file according to v3.7.x
derrabus added a commit to derrabus/migrations that referenced this pull request Mar 1, 2024
@derrabus
Merge branch '3.8.x' into 4.0.x
00dcbf1 
* 3.8.x:
  Adjust PHPStan settings for ORM 3 and DBAL 4 (doctrine#1404)
  Flatten directory tree
  Switch to attributes in docs (doctrine#1392)
  chore: Add missing option in MigrateCommand help section
  ci: fix variable reference (doctrine#1385)
  Fix formatParameter() for boolean (doctrine#1377)
  doctrineGH-1379: Improve Deprecation thrown check + logic
  Updated documentation for config-cli.php file according to v3.7.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
3.7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jderusse @derrabus @stof