Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions UPGRADE.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
# Upgrade to 2.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to keep this for 3.6, as we don't have a way to stop users from upgrading...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.0 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so...

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On 4 January 2015 at 03:51, Kim Hemsø Rasmussen [email protected]
wrote:

In UPGRADE.md
#767 (diff):

@@ -1,3 +1,10 @@
+# Upgrade to 2.6

3.0 ?


Reply to this email directly or view it on GitHub
https://github.com/doctrine/dbal/pull/767/files#r22436191.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing it is a BC break, so removing it would force to go to 3.0 (or to stop following semver, which would be a pain for all Composer users)


## BC BREAK: Drizzle support have been removed.

Project is dead. Development have stopped and project pages like http://docs.drizzle.org/ has
been down in a very long time.

# Upgrade to 2.5.1

## MINOR BC BREAK: Doctrine\DBAL\Schema\Table
Expand Down
26 changes: 2 additions & 24 deletions docs/en/reference/configuration.rst
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,8 @@ full driver name::

pdo-mysql://localhost:4486/foo?charset=UTF-8

If you wanted to use the ``drizzle_pdo__mysql`` driver instead::

drizzle-pdo-mysql://localhost:4486/foo?charset=UTF-8

In the two last example above, mind the dashes instead of the
In the example above, mind the dashes instead of the
underscores in the URL schemes.

For connecting to an SQLite database, the authority portion of the
Expand Down Expand Up @@ -130,8 +127,6 @@ interfaces to use. It can be configured in one of three ways:

- ``pdo_mysql``: A MySQL driver that uses the pdo\_mysql PDO
extension.
- ``drizzle_pdo_mysql``: A Drizzle driver that uses pdo\_mysql PDO
extension.
- ``mysqli``: A MySQL driver that uses the mysqli extension.
- ``pdo_sqlite``: An SQLite driver that uses the pdo\_sqlite PDO
extension.
Expand Down Expand Up @@ -203,23 +198,6 @@ pdo\_mysql
- ``charset`` (string): The charset used when connecting to the
database.

drizzle\_pdo\_mysql
^^^^^^^^^^^^^^^^^^^

**Requires** drizzle plugin ``mysql_protocol`` or ``mysql_unix_socket_protocol`` to be enabled.
On Ubuntu this can be done by editing ``/etc/drizzle/conf.d/mysql-protocol.cnf``
or ``/etc/drizzle/conf.d/mysql-unix-socket-protocol.cnf`` and restart drizzled daemon.

- ``user`` (string): Username to use when connecting to the
database. Only needed if authentication is configured for drizzled.
- ``password`` (string): Password to use when connecting to the
database. Only needed if authentication is configured for drizzled.
- ``host`` (string): Hostname of the database to connect to.
- ``port`` (integer): Port of the database to connect to.
- ``dbname`` (string): Name of the database/schema to connect to.
- ``unix_socket`` (string): Name of the socket used to connect to
the database.

mysqli
^^^^^^

Expand Down Expand Up @@ -285,7 +263,7 @@ pdo\_oci / oci8
database.
- ``instancename`` (string): Optional parameter, complete whether to
add the INSTANCE_NAME parameter in the connection. It is generally used
to connect to an Oracle RAC server to select the name of a particular instance.
to connect to an Oracle RAC server to select the name of a particular instance.


pdo\_sqlsrv / sqlsrv
Expand Down
1 change: 0 additions & 1 deletion docs/en/reference/introduction.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ The following database vendors are currently supported:
- PostgreSQL
- SAP Sybase SQL Anywhere
- SQLite
- Drizzle

The Doctrine 2 database layer can be used independently of the
object-relational mapper. In order to use the DBAL all you need is
Expand Down
5 changes: 0 additions & 5 deletions docs/en/reference/platforms.rst
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,6 @@ SQLite

- ``SqlitePlatform`` for all versions.

Drizzle
^^^^^^

- ``DrizzlePlatform`` for all versions.

It is highly encouraged to use the platform class that matches your
database vendor and version best. Otherwise it is not guaranteed
that the compatibility in terms of SQL dialect and feature support
Expand Down
8 changes: 4 additions & 4 deletions docs/en/reference/schema-representation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,10 @@ The following options are not completely portable but are supported by most of t
vendors:

- **unsigned** (boolean): Whether a ``smallint``, ``integer`` or ``bigint`` Doctrine
type column should allow unsigned values only. Supported by MySQL, SQL Anywhere
and Drizzle. Defaults to ``false``.
type column should allow unsigned values only. Supported by MySQL and SQL Anywhere.
Defaults to ``false``.
- **comment** (integer|string): The column comment. Supported by MySQL, PostgreSQL,
Oracle, SQL Server, SQL Anywhere and Drizzle. Defaults to ``null``.
Oracle, SQL Server and SQL Anywhere. Defaults to ``null``.

Vendor specific options
^^^^^^^^^^^^^^^^^^^^^^^
Expand All @@ -133,7 +133,7 @@ The following options are completely vendor specific and absolutely not portable
supported by some vendors but not portable:

- **charset** (string): The character set to use for the column. Currently only supported
on MySQL and Drizzle.
on MySQL.
- **collate** (string): The collation to use for the column. Currently only supported on
SQL Server.
- **check** (string): The check constraint clause to add to the column.
Expand Down
36 changes: 0 additions & 36 deletions docs/en/reference/types.rst

Large diffs are not rendered by default.

42 changes: 0 additions & 42 deletions lib/Doctrine/DBAL/Driver/DrizzlePDOMySql/Connection.php

This file was deleted.

78 changes: 0 additions & 78 deletions lib/Doctrine/DBAL/Driver/DrizzlePDOMySql/Driver.php

This file was deleted.

20 changes: 9 additions & 11 deletions lib/Doctrine/DBAL/DriverManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ final class DriverManager
'ibm_db2' => 'Doctrine\DBAL\Driver\IBMDB2\DB2Driver',
'pdo_sqlsrv' => 'Doctrine\DBAL\Driver\PDOSqlsrv\Driver',
'mysqli' => 'Doctrine\DBAL\Driver\Mysqli\Driver',
'drizzle_pdo_mysql' => 'Doctrine\DBAL\Driver\DrizzlePDOMySql\Driver',
'sqlanywhere' => 'Doctrine\DBAL\Driver\SQLAnywhere\Driver',
'sqlsrv' => 'Doctrine\DBAL\Driver\SQLSrv\Driver',
);
Expand Down Expand Up @@ -92,7 +91,6 @@ private function __construct()
* sqlanywhere
* sqlsrv
* ibm_db2 (unstable)
* drizzle_pdo_mysql
*
* OR 'driverClass' that contains the full class name (with namespace) of the
* driver class to instantiate.
Expand Down Expand Up @@ -142,7 +140,7 @@ public static function getConnection(
}

$params = self::parseDatabaseUrl($params);

// check for existing pdo object
if (isset($params['pdo']) && ! $params['pdo'] instanceof \PDO) {
throw DBALException::invalidPdoInstance();
Expand Down Expand Up @@ -227,23 +225,23 @@ private static function parseDatabaseUrl(array $params)
if (!isset($params['url'])) {
return $params;
}

// (pdo_)?sqlite3?:///... => (pdo_)?sqlite3?://localhost/... or else the URL will be invalid
$url = preg_replace('#^((?:pdo_)?sqlite3?):///#', '$1://localhost/', $params['url']);

$url = parse_url($url);

if ($url === false) {
throw new DBALException('Malformed parameter "url".');
}

if (isset($url['scheme'])) {
$params['driver'] = str_replace('-', '_', $url['scheme']); // URL schemes must not contain underscores, but dashes are ok
if (isset(self::$driverSchemeAliases[$params['driver']])) {
$params['driver'] = self::$driverSchemeAliases[$params['driver']]; // use alias like "postgres", else we just let checkParams decide later if the driver exists (for literal "pdo-pgsql" etc)
}
}

if (isset($url['host'])) {
$params['host'] = $url['host'];
}
Expand All @@ -256,21 +254,21 @@ private static function parseDatabaseUrl(array $params)
if (isset($url['pass'])) {
$params['password'] = $url['pass'];
}

if (isset($url['path'])) {
if (!isset($url['scheme']) || (strpos($url['scheme'], 'sqlite') !== false && $url['path'] == ':memory:')) {
$params['dbname'] = $url['path']; // if the URL was just "sqlite::memory:", which parses to scheme and path only
} else {
$params['dbname'] = substr($url['path'], 1); // strip the leading slash from the URL
}
}

if (isset($url['query'])) {
$query = array();
parse_str($url['query'], $query); // simply ingest query as extra params, e.g. charset or sslmode
$params = array_merge($params, $query); // parse_str wipes existing array elements
}

return $params;
}
}
Loading