Skip to content

Conversation

@kimhemsoe
Copy link
Member

No description provided.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-1105

We use Jira to track the state of pull requests and the versions they got
included in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to keep this for 3.6, as we don't have a way to stop users from upgrading...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.0 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so...

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On 4 January 2015 at 03:51, Kim Hemsø Rasmussen [email protected]
wrote:

In UPGRADE.md
#767 (diff):

@@ -1,3 +1,10 @@
+# Upgrade to 2.6

3.0 ?


Reply to this email directly or view it on GitHub
https://github.com/doctrine/dbal/pull/767/files#r22436191.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing it is a BC break, so removing it would force to go to 3.0 (or to stop following semver, which would be a pain for all Composer users)

@stof
Copy link
Member

stof commented Jan 17, 2015

it could be marked as deprecated though

@SenseException
Copy link
Member

@stof That makes sense. It would be a surprise for Drizzle users if the support would suddenly vanish.

@Ocramius
Copy link
Member

This will not land in 2.x anyway, adding a [3.0] to the title

@Ocramius Ocramius changed the title Removed drizzle support. [3.0] Removed drizzle support. Jan 17, 2015
@SenseException
Copy link
Member

So how about deprecation in 2.x versions? Maybe starting in version 2.6 (If there will be one of course).

@Ocramius
Copy link
Member

@SenseException the PR as-is is fine, it will just be merged once we have a schedule for 3.0

@deeky666 deeky666 added this to the 3.0 milestone Jan 10, 2016
@kimhemsoe kimhemsoe mentioned this pull request Mar 7, 2018
@Majkl578 Majkl578 closed this Mar 8, 2018
@morozov morozov removed this from the 4.0.0 milestone Mar 19, 2020
@kimhemsoe kimhemsoe deleted the drizzle_remove branch November 17, 2020 14:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants