-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[3.0] Removed drizzle support. #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1105 We use Jira to track the state of pull requests and the versions they got |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to keep this for 3.6, as we don't have a way to stop users from upgrading...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.0 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so...
Marco Pivetta
http://ocramius.github.com/
On 4 January 2015 at 03:51, Kim Hemsø Rasmussen [email protected]
wrote:
In UPGRADE.md
#767 (diff):@@ -1,3 +1,10 @@
+# Upgrade to 2.63.0 ?
—
Reply to this email directly or view it on GitHub
https://github.com/doctrine/dbal/pull/767/files#r22436191.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing it is a BC break, so removing it would force to go to 3.0 (or to stop following semver, which would be a pain for all Composer users)
|
it could be marked as deprecated though |
|
@stof That makes sense. It would be a surprise for Drizzle users if the support would suddenly vanish. |
|
This will not land in 2.x anyway, adding a |
|
So how about deprecation in 2.x versions? Maybe starting in version 2.6 (If there will be one of course). |
|
@SenseException the PR as-is is fine, it will just be merged once we have a schedule for 3.0 |
No description provided.