Bind only non-NULL BLOB values as BLOB on oci8 and ibm_db2#5466
Merged
morozov merged 1 commit intodoctrine:3.3.xfrom Jun 26, 2022
Merged
Bind only non-NULL BLOB values as BLOB on oci8 and ibm_db2#5466morozov merged 1 commit intodoctrine:3.3.xfrom
morozov merged 1 commit intodoctrine:3.3.xfrom
Conversation
morozov
force-pushed
the
issues/5359
branch
3 times, most recently
from
988e765 to
ed5de29
Compare
morozov
commented
Jun 25, 2022
greg0ire
approved these changes
Jun 26, 2022
fabacino
reviewed
Jun 27, 2022
| $variable =& $lob; | ||
| $variable =& $lob; | ||
| } else { | ||
| $type = ParameterType::STRING; |
There was a problem hiding this comment.
Just out of curiosity, why did you choose ParameterType::STRING here over ParameterType::NULL?
Member
Author
There was a problem hiding this comment.
There’s no special handling of the null parameters in oci8.
morozov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5359.