CI for Oracle DB by FaritSlv · Pull Request #9862 · doctrine/orm

FaritSlv · 2022-06-24T23:28:36Z

Try running the tests on Oracle

.github/workflows/continuous-integration.yml

tests/Doctrine/Tests/TestUtil.php

Co-authored-by: Alexander M. Turek <me@derrabus.de>

.github/workflows/continuous-integration.yml

Co-authored-by: Alexander M. Turek <me@derrabus.de>

[~] Intermediate commit

[~] I'm thinking about optimizing the oracle db container

tests/Doctrine/Tests/ORM/Mapping/AbstractMappingDriverTest.php

FaritSlv · 2022-07-06T08:36:28Z

I tried several options. Running out of ideas

On the local, I found out that the Oracle DB at some point starts blocking requests or hangs up due to a large number of reads and writes. Tried to disable all possible logging. Autocommits.

The test passes on the github, because the process hangs for a long time, then the database comes to life and goes on. And so several times, because of this for so long

@greg0ire, any ideas where else to go?

FaritSlv · 2022-07-06T16:22:03Z

Stuck on the 1080th test, eventually restarted the database container

FaritSlv · 2022-07-06T16:23:23Z

Individually, all tests pass quickly.

greg0ire · 2022-07-06T19:09:30Z

@greg0ire, any ideas where else to go?

No, the only experience with Oracle I have is with the PR you started from.

FaritSlv · 2022-07-10T11:48:32Z

Hi
@derrabus, @morozov, @greg0ire

After adding this fix doctrine/dbal#768, there may have been a profit, but only if you run each test separately. But when all the tests are done, it eats up all the resources of Oracle, and this is very sensitive for the Express Edition. If you return it to joins, then the tests will pass even locally. There is something to think about, for example, tests pass more or less quickly, but one test freezes for 40 minutes "\Doctrine\Tests\ORM\Functional\SchemaTool\CompanySchemaTest::testGeneratedSchema", as I understand it, the bottleneck is getting metadata. I think Oracleplatform can be improved in dbal

morozov · 2022-07-10T17:21:11Z

The optimization made in doctrine/dbal#768 may be irrelevant as of doctrine/dbal#5268. The Oracle's system views indeed take a while to initialize but this has been mitigated by querying them once for the entire schema introspection as opposed to querying them once per table.

We can consider reverting the previous optimization and using joins instead of sub-queries.

� Conflicts: � lib/Doctrine/ORM/Persisters/Collection/ManyToManyPersister.php � tests/Doctrine/Tests/ORM/Functional/EntityRepositoryTest.php � tests/Doctrine/Tests/ORM/Functional/Ticket/DDC192Test.php � tests/Doctrine/Tests/ORM/Functional/Ticket/DDC3634Test.php � tests/Doctrine/Tests/ORM/Functional/Ticket/DDC6303Test.php � tests/Doctrine/Tests/ORM/Functional/xml/Doctrine.Tests.Models.OrnementalOrphanRemoval.Person.dcm.xml � tests/Doctrine/Tests/ORM/Functional/xml/Doctrine.Tests.Models.OrnementalOrphanRemoval.PhoneNumber.dcm.xml � tests/Doctrine/Tests/OrmFunctionalTestCase.php � tests/Doctrine/Tests/TestUtil.php

FaritSlv · 2022-09-22T13:44:01Z

@greg0ire, I apologize, when resolve merge-conflicts I did not see the connection to oracle. Please run action

greg0ire · 2022-09-22T14:53:56Z

Can you create a separate PR with a non-controversial commit? That way, once it is merged, you will not have to wait for us to click the "run action" button on this PR as you will be trusted.

FaritSlv · 2022-09-22T17:36:28Z

Can you create a separate PR with a non-controversial commit? That way, once it is merged, you will not have to wait for us to click the "run action" button on this PR as you will be trusted.

Ок

FaritSlv · 2022-09-22T21:03:00Z

Can you create a separate PR with a non-controversial commit? That way, once it is merged, you will not have to wait for us to click the "run action" button on this PR as you will be trusted.

Resolve
Static Analysis, Continuous Integration, Performance benchmark, Coding Standards

derrabus · 2022-09-23T12:55:40Z

lib/Doctrine/ORM/Persisters/Collection/ManyToManyPersister.php

        $offset = $criteria->getFirstResult();

-        return $this->platform->modifyLimitQuery('', $limit, $offset ?? 0);
+        if ($limit !== null || $offset !== null) {


Why is this necessary? Also note that with regards to $offset, zero and null should be treated equally. In fact, null should be deprecated by now.

Is it better to check if it is greater than zero?

No, it would be better to not change this line. I want to understand why you do.

And if we need this change, make sure that the values 0 and null for $offset create the same query. I was like this before your change.

derrabus · 2022-09-23T12:58:18Z

tests/Doctrine/Tests/Models/CMS/CmsUser.php

                            [
                                'name'      => 'phonenumbers.phonenumber',
-                                'column'    => 'number',
+                                'column'    => '`number`',


I think we should rename the column.

tests/Doctrine/Tests/Models/OneToOneInverseSideLoad/InverseSide.php

FaritSlv · 2022-10-23T16:42:32Z

@derrabus, what else is required of me?

derrabus · 2022-10-23T21:08:53Z

Sorry that this PR takes so long to get merged. The main issue is that the PR does not only add Oracle to the build matrix, it also changes a lot of code that at first glance is not specific to Oracle. This makes the changes hard to understand for us.

FaritSlv · 2022-10-24T07:23:03Z

Sorry that this PR takes so long to get merged. The main issue is that the PR does not only add Oracle to the build matrix, it also changes a lot of code that at first glance is not specific to Oracle. This makes the changes hard to understand for us.

@derrabus, ok, i'm all understanding. Won't be surprised if they don't merge this PR, because very big

derrabus · 2022-10-24T07:37:11Z

One thing you can do is to isolate changes and submit them as individual PRs. Smaller, focused PRs are usually easier to review and get merged more quickly.

FaritSlv · 2022-10-24T07:52:43Z

One thing you can do is to isolate changes and submit them as individual PRs. Smaller, focused PRs are usually easier to review and get merged more quickly.

So the problem is that all the changes are related. I will think how to split

github-actions · 2024-11-12T03:04:00Z

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

github-actions · 2024-11-20T03:10:51Z

This pull request was closed due to inactivity.

CI for Oracle DB

25ef61a

beberlei reviewed Jun 25, 2022

View reviewed changes

.github/workflows/continuous-integration.yml Show resolved Hide resolved

derrabus reviewed Jun 27, 2022

View reviewed changes

tests/Doctrine/Tests/TestUtil.php Outdated Show resolved Hide resolved

Update tests/Doctrine/Tests/TestUtil.php

4c04bf8

Co-authored-by: Alexander M. Turek <me@derrabus.de>

derrabus reviewed Jun 29, 2022

View reviewed changes

.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved

FaritSlv and others added 12 commits June 29, 2022 13:49

Upgrade DBAL version for CI

2071e95

Co-authored-by: Alexander M. Turek <me@derrabus.de>

Resolve error

6eaf9c2

[~] Intermediate commit

Merge branch 'oracle' of github.com:FaritSlv/orm into oracle

c60c6cb

Upgrade version Oracle DB

add8a3b

Revert lower-case

cd345f8

Revert oci8.xml

af96985

Small refactoring

2fdb12a

Fix for reserved words

5549b07

Fix limit

da95295

Fix error and coding-standards

8eb0c41

Resolve errors

ab03130

Finished resolve errors and failures.

c164fca

[~] I'm thinking about optimizing the oracle db container

FaritSlv commented Jul 5, 2022

View reviewed changes

tests/Doctrine/Tests/ORM/Mapping/AbstractMappingDriverTest.php Outdated Show resolved Hide resolved

Optimize all drop tables

1afc225

FaritSlv force-pushed the oracle branch from 18a6565 to 1afc225 Compare July 5, 2022 10:55

derrabus marked this pull request as ready for review July 6, 2022 10:26

FaritSlv mentioned this pull request Jul 6, 2022

Fix warning: bind null value in a BLOB field oci8 #9700

Closed

Resolve last errors

ae1cd5a

derrabus marked this pull request as draft July 7, 2022 08:14

FaritSlv added 2 commits September 21, 2022 22:58

Resolve merge conflicts and revert settings CI

0350979

FaritSlv requested review from beberlei, derrabus and greg0ire and removed request for beberlei, derrabus, greg0ire and morozov September 21, 2022 20:26

FaritSlv added 2 commits September 22, 2022 09:03

Merge branch '2.13.x' of github.com:FaritSlv/orm into oracle

2ead0f8

Fix connection for Oracle in test

4db412b

Fix CI settings

886dac6

FaritSlv added 2 commits September 22, 2022 23:27

Resolve test DDC192

9ed5ef0

Coding standard

660807f

derrabus reviewed Sep 23, 2022

View reviewed changes

greg0ire removed their request for review June 22, 2023 20:44

github-actions bot added the Stale label Nov 12, 2024

github-actions bot closed this Nov 20, 2024

Comments

Conversation

FaritSlv commented Jun 24, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FaritSlv commented Jul 6, 2022

Uh oh!

FaritSlv commented Jul 6, 2022

Uh oh!

FaritSlv commented Jul 6, 2022

Uh oh!

greg0ire commented Jul 6, 2022

Uh oh!

FaritSlv commented Jul 10, 2022 • edited by morozov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

morozov commented Jul 10, 2022

Uh oh!

FaritSlv commented Sep 22, 2022

Uh oh!

greg0ire commented Sep 22, 2022

Uh oh!

FaritSlv commented Sep 22, 2022

Uh oh!

FaritSlv commented Sep 22, 2022

Uh oh!

derrabus Sep 23, 2022

Choose a reason for hiding this comment

Uh oh!

FaritSlv Sep 23, 2022

Choose a reason for hiding this comment

Uh oh!

derrabus Oct 23, 2022

Choose a reason for hiding this comment

Uh oh!

derrabus Oct 23, 2022

Choose a reason for hiding this comment

Uh oh!

derrabus Sep 23, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

FaritSlv commented Oct 23, 2022

Uh oh!

derrabus commented Oct 23, 2022

Uh oh!

FaritSlv commented Oct 24, 2022

Uh oh!

derrabus commented Oct 24, 2022

Uh oh!

FaritSlv commented Oct 24, 2022

Uh oh!

github-actions bot commented Nov 12, 2024

Uh oh!

github-actions bot commented Nov 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

FaritSlv commented Jul 10, 2022 •

edited by morozov

Loading