Update result node version and npm dependencies #140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
result
Node.js app was years out of date, and also had known vulnerabilities. This PR has a list of improvements and fixes that I've been using in my own version for months and in my Docker for Node.js course. I tried to make minimal changes with these goals:Changes include:
server.js
to support change in postgres driver syntax.npm ci
to ensure future builds don't break due to the difference between package.json and package-lock.json.ci
only uses package-lock.json so builds will use the versions we know to work.docker build
.Note: A separate PR #139 will prevent node_modules from being included in git commits and docker builds.