Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in result Dockerfile #135

Closed
wants to merge 1 commit into from
Closed

Fixed bug in result Dockerfile #135

wants to merge 1 commit into from

Conversation

FlyingBird95
Copy link

I ran the command:

docker-compose up

and it didn't worked because there was an error in the Dockerfile of result.

Therefore, I fixed it!

@BretFisher
Copy link
Collaborator

Can you give us the error you're seeing and your environment setup? I've not seen this issue before, so I'm assuming it's due to a unique environment.

@BretFisher
Copy link
Collaborator

I've built master on macOS and Windows 10 Pro (both with Docker Desktop 19.03.1) and don't get this error.

@BretFisher
Copy link
Collaborator

OK, my research shows that this error is caused by a long-standing on-and-off-again npm+alpine bug. npm has fixed it in 6.11, but we'll need to wait for that to be default in upstream official images, so choices are:

  1. Accept this PR workaround that slightly lowers the security of npm
  2. Install the newer npm in this image ourselves (which to get it installed, may still require this workaround)
  3. Use debian slim version of this image, which I've tested and works. It also prevents multiple other node/npm issues I've seen over the years with using node:alpine.

Since this is an example app that we would rather have minimal future issues with, I'm recommending the 3rd option and have added that to my result update PR #140

Once that's accepted we can close this issue. Thanks for the heads up @FlyingBird95

@JimCodified
Copy link

Verifying that PR #140 fixed this issue and we're OK to close this one? @FlyingBird95 @BretFisher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants