chore(release): add pre-release checks to make the release process more consistent #114
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the release process by adding pre-release validation checks to ensure consistency and reduce errors. The changes introduce a new check-pre-release target that verifies build files exist and versions match before proceeding with releases.
Key Changes
- Added
check-pre-releasemake target and corresponding shell script to validate pre-release state - Updated documentation to clarify the multi-step release process and GitHub Actions branch restrictions
- Modified
release-allto automatically run pre-release checks before proceeding
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| commons-test.mk | Added check-pre-release target that invokes validation script |
| RELEASING.md | Updated documentation with branch restrictions, multi-step release process, and pre-release check details |
| Makefile | Restructured to separate pre-release-all from release-all and added automatic check invocation |
| .github/scripts/check-pre-release.sh | New validation script that verifies build files exist and versions match |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mdelapenya
force-pushed
the
tune-release-more
branch
from
4235f34 to
cbb2e3b
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
* main: feat(wait): add human-readable String() methods to all wait strategies (docker#119) feat(image): display formatted pull progress on Windows terminals (docker#118) chore(release): add Go proxy refresh automation (docker#117) chore(release): bump module versions chore(release): prevent for pushing to personal forks (docker#115) chore(release): add pre-release checks to make the release process more consistent (docker#114) chore(volume): return pointer in FindByID (docker#105) fix(container): proper error message on empty container names (docker#113) fix(container): add to nil modifiers (docker#112) feat(container): add new functional options to add container config, hostConfig and endpointSettings (docker#111) feat(container): configure pull handler at container creation (docker#110)
1 participant
What does this PR do?
Adds a check-pre-release make goal so that the release process is more fail-tolerant.
Why is it important?
It also serves to verify the changes for a release before pushing the code: run pre-release with dry_run=false (to check the state), and release with dry_run