fix(container): proper error message on empty container names #113
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the error message for empty container names by renaming ErrReuseEmptyName to ErrContainerNameEmpty and updating its message to remove misleading "reuse" terminology that was likely carried over from testcontainers-go.
Key Changes:
- Renamed error variable from
ErrReuseEmptyNametoErrContainerNameEmpty - Updated error message to remove "reuse" context
- Added documentation to
WithNamefunction clarifying error behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| container/options.go | Renamed error variable and updated error message; added function documentation |
| container/options_test.go | Updated test to reference the renamed error variable |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
* main: feat(wait): add human-readable String() methods to all wait strategies (docker#119) feat(image): display formatted pull progress on Windows terminals (docker#118) chore(release): add Go proxy refresh automation (docker#117) chore(release): bump module versions chore(release): prevent for pushing to personal forks (docker#115) chore(release): add pre-release checks to make the release process more consistent (docker#114) chore(volume): return pointer in FindByID (docker#105) fix(container): proper error message on empty container names (docker#113) fix(container): add to nil modifiers (docker#112) feat(container): add new functional options to add container config, hostConfig and endpointSettings (docker#111) feat(container): configure pull handler at container creation (docker#110)
1 participant
What does this PR do?
It changes the
ErrReuseEmptyNameerror toErrContainerNameEmpty, updating the error message.Why is it important?
The reuse words were probably part of the fork of testcontainers-go
Related issues