This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Fix removing of cgroups if something still alive in container #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgroups/utils.go
Outdated
Contributor
There was a problem hiding this comment.
nit: reword?
s/this strange way of checking cgroups existence we need/We need this strange way of checking cgroups existence/
Now we try to remove cgroups 5 times with increased delay between tries. Signed-off-by: Alexander Morozov <[email protected]>
Contributor
Author
|
@rjnagal Fixed, thanks for review. |
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
rjnagal
added a commit
that referenced
this pull request
Dec 23, 2014
Fix removing of cgroups if something still alive in container
ColinHuang
pushed a commit
to fcwu/docker
that referenced
this pull request
Jan 5, 2015
This commit contains changes for docker: * user.GetGroupFile to user.GetGroupPath docker-archive/libcontainer#301 * Add systemd support for OOM docker-archive/libcontainer#307 * Support for custom namespaces docker-archive/libcontainer#279, docker-archive/libcontainer#312 * Fixes moby#9699 docker-archive/libcontainer#308 Signed-off-by: Alexander Morozov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we try to remove cgroups 5 times with increased delay between
tries.
I tried with docker and this fixed moby/moby#9699 for me.