Change namespaces config to include path for setns #279
Conversation
|
@LK4D4 what do you think about his for the network work that is being done? |
|
Hmm, so docker will set the namespace path for --net=container:<> and --ipc=container:<>? It might not be backwards compatible, though, right? |
|
@mrunalp yes. The struct change is not backward compat but it's much more straight forward. |
There was a problem hiding this comment.
I actually didn't got this trick. This is something like _, ok := container.Namespaces[name]?
|
I do like this better and makes potentially adding new namespaces in the future easier. |
|
Let me rebase |
crosbymichael
force-pushed
the
namespaces-join
branch
from
8a73d56 to
b4b1e92
Compare
|
This has been rebased |
|
I think I agree with @LK4D4 about using a map. Just a minor nit, otherwise LGTM. |
|
Ok, i'll look into it |
namespaces/init.go
Outdated
There was a problem hiding this comment.
I can't parse this comment.
This changes the namespace configuration on the config to include the name of the namespace along with an optional path. This path is used to point to a file of another namespace for the namespace so that it can be joined in place of the empty, initialized namespace. Signed-off-by: Michael Crosby <[email protected]>
crosbymichael
force-pushed
the
namespaces-join
branch
from
b4b1e92 to
549f508
Compare
|
This should be good now |
This removes the unsued namespace types from the namespace package and simplifies getting the values for the namespaces. Signed-off-by: Michael Crosby <[email protected]>
|
LGTM |
|
@mrunalp ok to merge? |
|
Yep, @rjnagal LGTM. |
Change namespaces config to include path for setns
This commit contains changes for docker: * user.GetGroupFile to user.GetGroupPath docker-archive/libcontainer#301 * Add systemd support for OOM docker-archive/libcontainer#307 * Support for custom namespaces docker-archive/libcontainer#279, docker-archive/libcontainer#312 * Fixes moby#9699 docker-archive/libcontainer#308 Signed-off-by: Alexander Morozov <[email protected]>
5 participants
This changes the namespace configuration on the config to include the
name of the namespace along with an optional path. This path is used to
point to a file of another namespace for the namespace so that it can be
joined in place of the empty, initialized namespace.
Closes #283
Signed-off-by: Michael Crosby [email protected]