Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix latest version selection #257

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

lukasweber
Copy link
Contributor

This is a draft PR for the version selection issues that believe to have discovered in #255.

I didn't get the time so far to test it, nor to update the tests. Feel free to continue :) Otherwise I will finish it as soon as I get some more time to test it better.

Let me know what you think.

@randombenj randombenj force-pushed the fix/latest-version-selection branch from 96ed16a to c35f21b Compare September 12, 2022 11:18
@randombenj randombenj self-requested a review September 12, 2022 11:19
Copy link
Member

@randombenj randombenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! I fixed some failing stuff and we can merge it when CI passes 😄

@randombenj randombenj marked this pull request as ready for review September 12, 2022 11:21
@randombenj randombenj added the bug Something isn't working label Sep 12, 2022
@randombenj randombenj merged commit 6f9652c into docat-org:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants