Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ProjectVersion breaks version comparing #255

Closed
lukasweber opened this issue Sep 6, 2022 · 0 comments
Closed

New ProjectVersion breaks version comparing #255

lukasweber opened this issue Sep 6, 2022 · 0 comments

Comments

@lukasweber
Copy link
Contributor

Hi,

I might be wrong, but could it be that the #239 PR broke the selection of the latest version at multiple places?

I discovered this when clicking on a project in the latest release and realizing that I'm on a very old version :)

If I understood it correctly, the data structure being sent won't contain a version with the name latest anymore. Instead, a tags property contains this information.

{
    "name": "my-project",
    "versions": [
        {
            "name": "1.9",
            "tags": []
        },
        {
            "name": "1.15",
            "tags": [
                "latest"
            ]
        }
     ]
}

However, Project.vue for example still does the searching for the latest version based on the name:

this.latestVersion = (this.versions.find((version) => version.name == 'latest') || this.versions[0]).name

Without diving deeper, it looks like same goes for Docs.vue.

If I get some time soon, I will try to fix this. I think it would be great to get rid of this bug soon, since it probably affects many projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants