Skip to content

Support XGBoost classifiers with num_class > 2, num_parallel_tree > 1 - #383

Merged
chyunsu3 merged 7 commits into
dmlc:mainlinefrom
chyunsu3:xgb_parallel_trees
May 21, 2022
Merged

chyunsu3 merged 7 commits into
dmlc:mainlinefrom
chyunsu3:xgb_parallel_trees

Conversation

@chyunsu3

Copy link
Copy Markdown
Collaborator

FYI @trivialfis

This PR uses tree_info field to deduce num_parallel_tree. XGBoost 1.6+ also saves num_parallel_tree in the model, but we would like to support older XGBoost models too.

@codecov

codecov Bot commented May 21, 2022

Copy link
Copy Markdown

Codecov Report

Merging #383 (a2d31e8) into mainline (61f7d9a) will increase coverage by 0.29%.
The diff coverage is 97.19%.

@@              Coverage Diff               @@
##             mainline     #383      +/-   ##
==============================================
+ Coverage       84.93%   85.23%   +0.29%     
+ Complexity         44       42       -2     
==============================================
  Files             108      108              
  Lines            8665     8732      +67     
  Branches          510      523      +13     
==============================================
+ Hits             7360     7443      +83     
+ Misses           1281     1266      -15     
+ Partials           24       23       -1     
Impacted Files Coverage Δ
src/frontend/xgboost/xgboost_json.h 88.49% <89.47%> (+0.53%) ⬆️
src/frontend/xgboost_json.cc 71.27% <97.29%> (+1.70%) ⬆️
src/frontend/xgboost.cc 80.08% <100.00%> (+1.76%) ⬆️
tests/cpp/test_frontend.cc 94.44% <100.00%> (+0.41%) ⬆️
...src/main/java/ml/dmlc/treelite4j/java/DMatrix.java 55.81% <0.00%> (-13.96%) ⬇️
src/threading_utils/parallel_for.h 60.00% <0.00%> (-1.34%) ⬇️
include/treelite/tree.h 96.52% <0.00%> (+0.69%) ⬆️
python/treelite/frontend.py 75.72% <0.00%> (+0.86%) ⬆️
src/c_api/c_api.cc 95.59% <0.00%> (+2.71%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f7d9a...a2d31e8. Read the comment docs.

@chyunsu3
chyunsu3 merged commit 7da3f32 into dmlc:mainline May 21, 2022
@chyunsu3
chyunsu3 deleted the xgb_parallel_trees branch May 21, 2022 16:51
rapids-bot Bot pushed a commit to NVIDIA/cuml that referenced this pull request May 28, 2022
The 2.4.0 version of Treelite incorporates the following improvements:

* dmlc/treelite#370
* dmlc/treelite#381
* dmlc/treelite#380
* dmlc/treelite#383

Requires rapidsai/integration#474

This PR targets the 22.06 release.

Closes #4715

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #4752
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
The 2.4.0 version of Treelite incorporates the following improvements:

* dmlc/treelite#370
* dmlc/treelite#381
* dmlc/treelite#380
* dmlc/treelite#383

Requires rapidsai/integration#474

This PR targets the 22.06 release.

Closes NVIDIA#4715

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: NVIDIA#4752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant