[XGBoost 1.6] Handle pseudo-Huber loss with slope - #380
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## mainline #380 +/- ##
==============================================
+ Coverage 84.92% 84.95% +0.02%
Complexity 44 44
==============================================
Files 108 108
Lines 8663 8665 +2
Branches 510 510
==============================================
+ Hits 7357 7361 +4
+ Misses 1282 1280 -2
Partials 24 24
Continue to review full report at Codecov.
|
trivialfis
reviewed
May 15, 2022
| push_key_handler<IgnoreHandler>("aft_loss_param")); | ||
| push_key_handler<IgnoreHandler>("aft_loss_param") || | ||
| push_key_handler<IgnoreHandler>("pseduo_huber_param") || | ||
| push_key_handler<IgnoreHandler>("pseudo_huber_param")); |
Collaborator
Author
There was a problem hiding this comment.
The one is the mispelled version used in 1.6
This was referenced May 23, 2022
Merged
rapids-bot Bot
pushed a commit
to NVIDIA/cuml
that referenced
this pull request
May 28, 2022
The 2.4.0 version of Treelite incorporates the following improvements: * dmlc/treelite#370 * dmlc/treelite#381 * dmlc/treelite#380 * dmlc/treelite#383 Requires rapidsai/integration#474 This PR targets the 22.06 release. Closes #4715 Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Corey J. Nolet (https://github.com/cjnolet) URL: #4752
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
The 2.4.0 version of Treelite incorporates the following improvements: * dmlc/treelite#370 * dmlc/treelite#381 * dmlc/treelite#380 * dmlc/treelite#383 Requires rapidsai/integration#474 This PR targets the 22.06 release. Closes NVIDIA#4715 Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Corey J. Nolet (https://github.com/cjnolet) URL: NVIDIA#4752
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix all integration tests with XGBoost.