Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

update to use MKLDNN option #328

Closed
wants to merge 1 commit into from
Closed

Conversation

jinhuang415
Copy link

@jinhuang415 jinhuang415 commented Feb 27, 2018

MXNet has been moved to use MKLDNN instead of MKLML, so update the cmake option from USE_MKLML_MKL to USE_MKLDNN, for MXNet cmake options please refer to latest MXNet repo file CMakeLists.txt

This change is a followup for below MXNet issue, please help to merge this change to mshadow first and we can update MXNet side change later after this change:
apache/mxnet#9868

@jinhuang415
Copy link
Author

@pengzhao-intel Add Patric

@jinhuang415
Copy link
Author

@tqchen @piiswrong Would you help to review the PR in your proper time? Thanks.

@mike07026
Copy link

mxnet_option(USE_MKLDNN "Use MKLDNN variant of MKL (if MKL found)" ON IF USE_MKL_IF_AVAILABLE AND UNIX AND (NOT APPLE))

Does it mean that MKLDNN option does not support windows platform yet ?

@jinhuang415
Copy link
Author

@mike07026 MKLDNN doesn't have such restriction and can support Linux/MAC/Windows all, I think this flag need to be changed to enable support for them

@szha
Copy link
Member

szha commented Aug 4, 2019

This code base has been donated to the Apache MXNet project per #373, and repo is deprecated. Future development should continue in Apache MXNet.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jin Huang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@szha szha closed this Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants