This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
MKL and CMake #9868
Labels
Comments
I think it is safe to set USE_MKLML_MKL to be same as USE_MKLDNN. @cjolivier01 can you please confirm ? |
Ideally, we should use only USE_MKLDNN. But I needed to set up a PR to
change mshadow first. Without merging mkldnn, changing mshadow would break
mshadow. I think we can change mshadow now
…On Sat, Feb 24, 2018 at 11:39 AM Marco de Abreu ***@***.***> wrote:
@zheng-da <https://github.com/zheng-da>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9868 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAETUeT1zkgM8pIuKLcoA-a0znd7YM7vks5tX-bxgaJpZM4SQcDN>
.
|
@jinhuang415 please take a look for this issue and file a PR to fix. |
I don’t know what’s still left of USE_MKLML_MKL, so I’ll leave it to @zheng-da’s judgement |
...or @pengzhao-intel or @jinhuang415 or someone who is more familiar with the changes |
Looks USE_MKLML_MKL is duplicate with USE_MKLDNN, as @zheng-da indicates, we may need 2 separate PRs for this, one to change mshadow to replace USE_MKLML_MKL with USE_MKLDNN, another one to remove USE_MKLML_MKL in mxnet and update mshadow link hash. |
We will take care of this issue. |
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Looking at the CMake with MKL I noticed there is an option there called
USE_MKLML_MKL
which has the same docstring asUSE_MKLDNN
; from what I can tell it is there for support with mshadow, would it not be safer to setUSE_MKLML_MKL
to be the same asUSE_MKLDNN
? Alternatively the docstring could indicate one is for mxnet and the other mshadow.The text was updated successfully, but these errors were encountered: