parametric NDArray #331
parametric NDArray #331
Conversation
src/executor.jl
Outdated
| G<:AbstractVector{<:Union{Void,NDArray}}, | ||
| O<:VecOfNDArray, | ||
| D<:Dict{Symbol,<:NDArray}, | ||
| E<:Dict{Symbol,<:NDArray}} |
There was a problem hiding this comment.
This is terrible, any better way to deal with abstract container type?
Or we need to redesign Executor?
iblislin
force-pushed
the
ib/param-nd
branch
2 times, most recently
from
c9cdd65
to
d49aa7a
Compare
|
with parametric NDArray, constructing julia> Dict(:x => x, :y => y)
Dict{Symbol,Any} with 2 entries:
:y => 6 mx.NDArray{Float32,1} @ CPU0:…
:x => 2×3 mx.NDArray{Float32,2} @ CPU0:… |
iblislin
force-pushed
the
ib/param-nd
branch
from
a7e7c2b
to
0ba8f69
Compare
iblislin
force-pushed
the
ib/param-nd
branch
from
be00070
to
8bd5f9d
Compare
|
hmm, I would like to avoid being resolved to Any if possible. |
|
Actually, same story on julia> x = [1,2]
2-element Array{Int64,1}:
1
2
julia> y = [1 2; 3 4]
2×2 Array{Int64,2}:
1 2
3 4
julia> Dict(:x => x, :y => y)
Dict{Symbol,Any} with 2 entries:
:y => [1 2; 3 4]
:x => [1, 2] |
src/metric.jl
Outdated
| mutable struct MSE <: AbstractEvalMetric | ||
| mse_sum :: Vector{NDArray} | ||
| mutable struct MSE{T<:NDArray} <: AbstractEvalMetric | ||
| mse_sum :: Vector{T} |
There was a problem hiding this comment.
@vchuravy I changed MSE like this, but I got confused that how does user initialize a MSE instance?
In the example of regression, it just creates a instance via MSE().
And...what's your design of struct MSE if we have parametric NDArray?
There was a problem hiding this comment.
Since this is for error reporting only it should simply default to Float64 or Float32.
The array is simply to not block during _update_single_output.
There was a problem hiding this comment.
Since this is for error reporting only it should simply default to
Float64orFloat32.
okay, I will init them with MX_float (Float32) by default.
The array is simply to not block during
_update_single_output.
I do not get what you mean.
iblislin
force-pushed
the
ib/param-nd
branch
from
e42f603
to
4bbef45
Compare
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
+ Coverage 70.01% 70.08% +0.07%
==========================================
Files 24 24
Lines 1944 1939 -5
==========================================
- Hits 1361 1359 -2
+ Misses 583 580 -3
Continue to review full report at Codecov.
|
|
This PR is ready for review now. |
|
good to go ? |
No description provided.