-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NDArray with parametric type? #323
Comments
BTW, what's the pros and cons if we make |
I have been wanting to make NDArray parametric for quite some time. #233 was one of the points where having it not be parametric caused big performance problems. |
ok, I want to make NDArray parametric first #331 |
I have no objection. What would the libmxnet function on NDArrays become? Are we going to define functions for all combinations of NDArrays or just define for the non-typed version? |
some of them benifit from dispatching, e.g. https://github.com/dmlc/MXNet.jl/pull/331/files#diff-0ca423d226049cc5744ebade856d9f1bR666 And most of functions are using UnionAll ( |
Thanks! This looks good to me. |
Should we make
NDArray
be parametric like Base'sArray
?One of the benefit I can tell is that it will help for multiple dispatch,
but how about the performance?
The text was updated successfully, but these errors were encountered: