Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly specify 7z #239

Merged
merged 1 commit into from
Apr 30, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion deps/build.jl
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ if !libmxnet_detected
run(`cmd /c copy "usr\\3rdparty\\openblas\\bin\\*.dll" "usr\\lib"`)

run(download_cmd(package_url, "mxnet.7z"))
run(`7z x mxnet.7z -y -ousr`)
exe7z = joinpath(JULIA_HOME, "7z.exe")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why joinpath with JULIA_HOME? Is 7z.exe shipped with Julia binary on windows?

run(`$exe7z x mxnet.7z -y -ousr`)

return
end
Expand Down