Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly specify 7z #239

Merged
merged 1 commit into from
Apr 30, 2017
Merged

explicitly specify 7z #239

merged 1 commit into from
Apr 30, 2017

Conversation

musm
Copy link
Contributor

@musm musm commented Apr 29, 2017

No description provided.

@musm
Copy link
Contributor Author

musm commented Apr 29, 2017

JuliaLang/julia#21540

@codecov-io
Copy link

codecov-io commented Apr 29, 2017 •
edited
Loading

Codecov Report

Merging #239 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #239   +/-   ##
=======================================
  Coverage   68.92%   68.92%           
=======================================
  Files          24       24           
  Lines        1860     1860           
=======================================
  Hits         1282     1282           
  Misses        578      578

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a530fa...2c30f11. Read the comment docs.

pluskid
pluskid reviewed Apr 29, 2017
View reviewed changes
deps/build.jl
@@ -43,7 +43,8 @@ if !libmxnet_detected
run(`cmd /c copy "usr\\3rdparty\\openblas\\bin\\*.dll" "usr\\lib"`)

run(download_cmd(package_url, "mxnet.7z"))
run(`7z x mxnet.7z -y -ousr`)
exe7z = joinpath(JULIA_HOME, "7z.exe")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why joinpath with JULIA_HOME? Is 7z.exe shipped with Julia binary on windows?

@pluskid
Copy link
Member

pluskid commented Apr 29, 2017

@musm Thanks a lot! LGTM. Can you clarify the minor question above?

@musm
Copy link
Contributor Author

musm commented Apr 29, 2017 •
edited
Loading

7z is shipped with Julia in Windows and the default windows juliarc file adds JULIA_HOME so that 7z is automatically added to path. The default juliarc behavior will go away in future version of Julia, see linked issue. So we will now need to explicitly specify the 7z path, which resided where JULIA_HOME is.

@pluskid pluskid merged commit 06010b8 into dmlc:master Apr 30, 2017
@pluskid
Copy link
Member

pluskid commented Apr 30, 2017

Thanks for the clarification!

@musm musm deleted the patch-1 branch April 30, 2017 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pluskid pluskid pluskid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@musm @codecov-io @pluskid