Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use push notifications for repository updates #10

Open
s-ludwig opened this issue Mar 18, 2013 · 9 comments
Open

Use push notifications for repository updates #10

s-ludwig opened this issue Mar 18, 2013 · 9 comments

Comments

@s-ludwig
Copy link
Member

The registry is currently living on the edge with it's GitHub API use. 60 non-cached requests per hour are allowed and jus registering two projects at once that contain some tags/branches will hit that limit.

When using OAuth2 to access the API, the limit gets increased to 2000 and it also becomes possible to use the PubSubHubbub API to avoid polling, making the registry more responsive and saving bandwith.

Bitbucket probably has something similar.

@eskimor
Copy link

eskimor commented Mar 19, 2013

I personally would not mind to release my software manually, via some "dub release" command, thus dub could be totally independent from github?

@s-ludwig
Copy link
Member Author

Well I would ;) For sure I will not remove that feature, it's one of the most important ones for me. Enabling releases that are not publically hosted may be a good enhancement, though. But that will require disk space to host the uploaded .zip files somewhere.

@eskimor
Copy link

eskimor commented Mar 20, 2013

Hosting packages seems to be a good idea:

  • Released versions are completely independent from the github repo, could be deleted, renamed, ...
  • Support for not publicly hosted packages/ or packages hosted on a non supported platform (no github/bitbucket)
  • Packages can contain different files than the repository. (E.g. only a sub-set, package.json gets enriched with the version extracted from the tag name directly, or applicable version() statements, ...)

Of course the resources would need to be provided somehow, maybe I could figure something out, I'll try as soon as I have some prototype of a building/hosting server implementation.

@p0nce
Copy link
Contributor

p0nce commented Sep 5, 2013

Do the registry absolutely need to poll github in the first place?
What I miss is a manual notification button in the dub registry website to avoid to wait 30 minutes when fixing an error. My current work-around is to delete package/re-add it which doesn't sound like a good idea in retrospect :)

@MartinNowak
Copy link
Member

I'll have a look at this when I find some time.

@MartinNowak
Copy link
Member

OK, I played around a little with the github API.
Webhooks are a nice thing, but we'd need the repo owner's OAuth access for the write:repo_hook scope to install them.
I still think, it's a good idea to implement this, so if I find even more time I'll do it.

@s-ludwig
Copy link
Member Author

Hm okay, that's a bit of a downer. Maybe there is a way to abuse something else? Maybe the "watch" functionality can be used to aggregate all changes, so that a single request gets all updates at once?

@MartinNowak
Copy link
Member

We could have a pseudo user, that watches all those repos. But from what I read you can't get notifications about commits. Watching only notifies about pull requests and comments.

@s-ludwig
Copy link
Member Author

I was hoping the the data of the "News feed" could be accessed, as that also contains "git push" notifications. But I'm not sure if those are for all watched repositories or just for the ones where the user has push access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants