Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert type hint to typing.List #1493

Merged
merged 5 commits into from
Sep 5, 2024
Merged

revert type hint to typing.List #1493

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cc32342
revert type hint to `typing.List`
defgsus Sep 5, 2024
127a5f5
Update test.yml to respect py 3.8
fsbraun Sep 5, 2024
74e21f5
Update test.yml to exclude py3.8/3.9 w/ dj50 in tests
fsbraun Sep 5, 2024
5cb2da1
Update CHANGELOG.rst
fsbraun Sep 5, 2024
571fa62
Bump version to 3.2.1
fsbraun Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ['3.10', '3.11', '3.12']
python-version: [3.8, 3.9, '3.10', '3.11', '3.12']
requirements-file: [
django-4.2.txt,
django-5.0.txt,
Expand All @@ -18,6 +18,15 @@ jobs:
os: [
ubuntu-20.04,
]
exclude:
- requirements-file: django-5.0.txt
python-version: 3.8
- requirements-file: django-5.0.txt
python-version: 3.9
- requirements-file: django-main.txt
python-version: 3.8
- requirements-file: django-main.txt
python-version: 3.9

steps:
- uses: actions/checkout@v1
Expand Down
2 changes: 1 addition & 1 deletion filer/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def clear_folder_permission_cache(user: User, permission: typing.Optional[str] =
cache.delete(get_folder_perm_cache_key(user, permission))


def update_folder_permission_cache(user: User, permission: str, id_list: list[int]) -> None:
def update_folder_permission_cache(user: User, permission: str, id_list: typing.List[int]) -> None:
"""
Updates the cached folder permissions for a given user and permission.

Expand Down
Loading