Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert type hint to typing.List #1493

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

defgsus
Copy link
Contributor

@defgsus defgsus commented Sep 5, 2024

Description

avoid using type hints that drop support of python 3.8 and 3.9

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.73%. Comparing base (b0f39ab) to head (127a5f5).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1493      +/-   ##
==========================================
+ Coverage   76.59%   76.73%   +0.14%     
==========================================
  Files          75       77       +2     
  Lines        3546     3624      +78     
  Branches      568      584      +16     
==========================================
+ Hits         2716     2781      +65     
- Misses        667      677      +10     
- Partials      163      166       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun
Copy link
Sponsor Member

fsbraun commented Sep 5, 2024

@defgsus Thanks so much for the quick fix!!

@fsbraun fsbraun merged commit b38ef8f into django-cms:master Sep 5, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants