Skip to content

Conversation

@thaJeztah
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.71%. Comparing base (343e590) to head (f0f7bf2).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   84.21%   83.71%   -0.50%     
==========================================
  Files           5        5              
  Lines         304      393      +89     
==========================================
+ Hits          256      329      +73     
- Misses         38       54      +16     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztah
Copy link
Member Author

Looks like CodeQL doesn't start because it's been a while since it ran;

Screenshot 2025-04-11 at 10 31 47

We could probably add a scheduled job for it as well

@thaJeztah
Copy link
Member Author

We could probably add a scheduled job for it as well

Interestingly, looks like we already have, so not sure why that didn't keep actions "alive"?;

on:
schedule:
- cron: '0 12 * * 6'
push:

@thaJeztah thaJeztah marked this pull request as ready for review April 11, 2025 10:44
@thaJeztah
Copy link
Member Author

The CodeCov is probably missing data, or it's just a rounding error 😓

Screenshot 2025-04-11 at 12 45 06

@thaJeztah
Copy link
Member Author

Not sure how to handle those 2 actions; I don't have access to the repo config, but it's worth checking how they're defined and if the repo-settings / branch protection needs updating (they're a big pain to set up if names change etc).

@milosgajdos
Copy link
Member

CodeQL Action major versions v1 and v2 have been deprecated. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2025-01-10-code-scanning-codeql-action-v2-is-now-deprecated/Show more

Need tot upgrade that workflow 😅

@thaJeztah
Copy link
Member Author

LOL; that's what this PR does. Fun chicken-and-egg case then?

@milosgajdos
Copy link
Member

I'm inclined to merge this. There is no way forward. Thoguhts?

@thaJeztah
Copy link
Member Author

Yeah, easiest is to remove them from the "required" checks in branch protection, then after it's merged, we can probably add them back

@milosgajdos
Copy link
Member

Done, let's merge

@thaJeztah
Copy link
Member Author

SGTM; I don't have permissions though ☺️

@milosgajdos milosgajdos merged commit e3db434 into distribution:main Apr 11, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants